Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8328482: Convert and Open source few manual applet test to main based #18448

Closed
wants to merge 14 commits into from

Conversation

TejeshR13
Copy link
Contributor

@TejeshR13 TejeshR13 commented Mar 22, 2024

Convert and open source these manual applet test to main based:
java/awt/Frame/MegaIconTest/MegaIconTest.html
java/awt/Frame/FrameMaximizedTest/FrameMaximizedTest.html
java/awt/Frame/FrameMinimizeTest/FrameMinimizeTest.html
java/awt/Frame/SizeMinimizedTest/SizeMinimizedTest.html

Automated the test SizeMinimizedTest.java. Since the test is failing Linux arch (Maybe related to the bug - JDK-8305915), the test is problem listed for Linux arch until the issue is fixed/further investigation is done.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8328482: Convert and Open source few manual applet test to main based (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18448/head:pull/18448
$ git checkout pull/18448

Update a local copy of the PR:
$ git checkout pull/18448
$ git pull https://git.openjdk.org/jdk.git pull/18448/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18448

View PR using the GUI difftool:
$ git pr show -t 18448

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18448.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 22, 2024

👋 Welcome back tr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 22, 2024

@TejeshR13 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8328482: Convert and Open source few manual applet test to main based

Reviewed-by: abhiscxk, honkar, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 34 new commits pushed to the master branch:

  • dd930c5: 8329787: Fix typo in CLDRConverter
  • 115f419: 8329659: Serial: Extract allowed_dead_ratio from ContiguousSpace
  • 9ac3b77: 8329775: Serial: Remove unused declarations in serialFullGC.hpp
  • 7475824: 8329510: Update ProblemList for JFileChooser/8194044/FileSystemRootTest.java
  • 6439375: 8329533: TestCDSVMCrash fails on libgraal
  • 3ebf8c9: 8329663: hs_err file event log entry for thread adding/removing should print current thread
  • be45de1: 8328627: JShell documentation should be clearer about "remote runtime system"
  • 8648890: 8329749: Obsolete the unused UseNeon flag
  • fc18201: 8327111: Replace remaining usage of create_bool_from_template_assertion_predicate() which requires additional OpaqueLoop*Nodes transformation strategies
  • 7c66465: 8325088: Overloads that differ in type parameters may be lost
  • ... and 24 more: https://git.openjdk.org/jdk/compare/0b01144ecec1283adaaaf1a7f53d075a56f030ae...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 22, 2024
@openjdk
Copy link

openjdk bot commented Mar 22, 2024

@TejeshR13 The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Mar 22, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 22, 2024

@prrace
Copy link
Contributor

prrace commented Mar 24, 2024

The images here are very problematic. I do not think they can be open-sourced.
You will need to remove these from the PR (ASAP) and replace them with something else.
The duke one is OK tho'

Copy link
Contributor

@kumarabhi006 kumarabhi006 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 2, 2024
@TejeshR13
Copy link
Contributor Author

@honkar-jdk Thank you for your inputs and suggestions. I have updated the test with ICONIFIED state and with windowStateChanged event.

test/jdk/java/awt/Frame/SizeMinimizedTest.java Outdated Show resolved Hide resolved
test/jdk/java/awt/Frame/SizeMinimizedTest.java Outdated Show resolved Hide resolved
test/jdk/java/awt/Frame/SizeMinimizedTest.java Outdated Show resolved Hide resolved
test/jdk/java/awt/Frame/SizeMinimizedTest.java Outdated Show resolved Hide resolved
test/jdk/java/awt/Frame/SizeMinimizedTest.java Outdated Show resolved Hide resolved
test/jdk/java/awt/Frame/SizeMinimizedTest.java Outdated Show resolved Hide resolved
Copy link
Contributor

@honkar-jdk honkar-jdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated changes look good.

test/jdk/ProblemList.txt Outdated Show resolved Hide resolved
Copy link
Contributor

@honkar-jdk honkar-jdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TejeshR13
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 10, 2024

Going to push as commit bea9acc.
Since your change was applied there have been 72 commits pushed to the master branch:

  • d037a59: 8311248: Refactor CodeCache::initialize_heaps to simplify adding new CodeCache segments
  • bab7019: 8329431: Improve speed of writing CDS heap objects
  • 47df145: 8310513: [s390x] Intrinsify recursive ObjectMonitor locking
  • b81b86d: 8329729: java/util/Properties/StoreReproducibilityTest.java times out
  • 6276789: 8328785: IOException: Symbol not found: C_GetInterface for PKCS11 interface prior to V3.0
  • 316361b: 8328318: Wrong description in X509Extension.getExtensionValue method javadoc
  • b80ba08: 8329967: Build failure after JDK-8329628
  • 4bba445: 8325659: Normalize Random usage by incubator vector tests
  • 6736792: 8329628: Additional changes after JDK-8329332
  • 1e02a13: 8328614: hsdis: dlsym can't find decode symbol
  • ... and 62 more: https://git.openjdk.org/jdk/compare/0b01144ecec1283adaaaf1a7f53d075a56f030ae...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 10, 2024
@openjdk openjdk bot closed this Apr 10, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 10, 2024
@openjdk
Copy link

openjdk bot commented Apr 10, 2024

@TejeshR13 Pushed as commit bea9acc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

4 participants