8328730: Convert java/awt/print/bug8023392/bug8023392.html applet test to main

[DamonGuy]

Convert java/awt/print/bug8023392/bug8023392.html applet test to main using PassFailJFrame

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8328730: Convert java/awt/print/bug8023392/bug8023392.html applet test to main (Bug - P4)

Reviewers

• Phil Race (@prrace - Reviewer) ⚠️ Review applies to 72fe9b13
• Harshitha Onkar (@honkar-jdk - Reviewer) ⚠️ Review applies to 72fe9b13

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18458/head:pull/18458
$ git checkout pull/18458

Update a local copy of the PR:
$ git checkout pull/18458
$ git pull https://git.openjdk.org/jdk.git pull/18458/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18458

View PR using the GUI difftool:
$ git pr show -t 18458

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18458.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dnguyen! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@DamonGuy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8328730: Convert java/awt/print/bug8023392/bug8023392.html applet test to main

Reviewed-by: prr, honkar

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 255 new commits pushed to the master branch:

• 27ac39a: 8328719: Convert java/awt/print/PageFormat/SetOrient.html applet test to main
• fb8f2a0: 8328562: Convert java/awt/InputMethods/DiacriticsTest/DiacriticsTest.java applet test to main
• 447436e: 8328948: GHA: Restoring sysroot from cache skips the build after JDK-8326960
• c7cf602: 8328385: Convert java/awt/FileDialog/FileDialogReturnTest test to main
• 78d1b90: 8328380: Remove applet usage from JColorChooser tests Test6348456
• 907e30f: 8325579: Inconsistent behavior in com.sun.jndi.ldap.Connection::createSocket
• 70a15c7: 8328825: Google CAInterop test failures
• a1fbbff: 8328717: Convert javax/swing/JColorChooser/8065098/bug8065098.java applet test to main
• 26b2ec4: 8328824: Clean up java.base native compilation
• af15c68: 8321278: C2: Partial peeling fails with assert "last_peel <- first_not_peeled"
• ... and 245 more: https://git.openjdk.org/jdk/compare/c65d308973f1e2c41b6910fd844223597e70972f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@DamonGuy The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (075d2f6d)
• 01: Full - Incremental (72fe9b13)
• 00: Full (26320f83)

[prsadhuk]

cant we use Graphics.drawChars instead in all places SwingUtilities2.drawChars is used?

[DamonGuy]

Graphics.drawChars isn't a static method, which will require additional changes to this test. Is it preferred to use Graphics over the SwingUtilities2 version?

[prrace]

This test is specifically about testing the spacing of text in Swing printing.
I think this SwingUtilities call isn't just "the way he happens to be printing text",
This call is the very thing under test ! And note that it takes a Component parameter
which affects how that call renders the text. It is used to figure out the FRC to use.
So changing this to use Graphics would be a problem.

[honkar-jdk]

LGTM

[DamonGuy]

/integrate

[openjdk]

Going to push as commit 4047a36.
Since your change was applied there have been 255 commits pushed to the master branch:

• 27ac39a: 8328719: Convert java/awt/print/PageFormat/SetOrient.html applet test to main
• fb8f2a0: 8328562: Convert java/awt/InputMethods/DiacriticsTest/DiacriticsTest.java applet test to main
• 447436e: 8328948: GHA: Restoring sysroot from cache skips the build after JDK-8326960
• c7cf602: 8328385: Convert java/awt/FileDialog/FileDialogReturnTest test to main
• 78d1b90: 8328380: Remove applet usage from JColorChooser tests Test6348456
• 907e30f: 8325579: Inconsistent behavior in com.sun.jndi.ldap.Connection::createSocket
• 70a15c7: 8328825: Google CAInterop test failures
• a1fbbff: 8328717: Convert javax/swing/JColorChooser/8065098/bug8065098.java applet test to main
• 26b2ec4: 8328824: Clean up java.base native compilation
• af15c68: 8321278: C2: Partial peeling fails with assert "last_peel <- first_not_peeled"
• ... and 245 more: https://git.openjdk.org/jdk/compare/c65d308973f1e2c41b6910fd844223597e70972f...master

Your commit was automatically rebased without conflicts.

[openjdk]

@DamonGuy Pushed as commit 4047a36.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.