Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8328825: Google CAInterop test failures #18459

Closed
wants to merge 1 commit into from

Conversation

rhalade
Copy link
Member

@rhalade rhalade commented Mar 22, 2024

Fix updates these tests to use OCSP or CRL revocation check with failover enabled. Intermediate root CA "WE3" doesn't specify OCSP responder in AIA extension. Check https://good.gsr4.demo.pki.goog/ for example.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8328825: Google CAInterop test failures (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18459/head:pull/18459
$ git checkout pull/18459

Update a local copy of the PR:
$ git checkout pull/18459
$ git pull https://git.openjdk.org/jdk.git pull/18459/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18459

View PR using the GUI difftool:
$ git pr show -t 18459

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18459.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 22, 2024

👋 Welcome back rhalade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 22, 2024

@rhalade This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8328825: Google CAInterop test failures

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

  • 29ba4b7: 8328705: GHA: Cross-compilation jobs do not require build JDK
  • f67ec19: 8079786: [macosx] Test java/awt/Frame/DisposeParentGC/DisposeParentGC.java fails for Mac only
  • 93579c2: 8323552: AbstractMemorySegmentImpl#mismatch returns -1 when comparing distinct areas of the same instance of MemorySegment
  • b235682: 8328709: AIX os::get_summary_cpu_info support Power 10
  • 19a0151: 8328700: Unused import and variable should be deleted in regex package
  • cf9b5a7: 8328776: [AIX] remove checked_vmgetinfo, use vmgetinfo directly
  • acc4a82: 8328862: Remove unused GrowableArrayFilterIterator
  • 9f920b9: 8324655: Identify integer minimum and maximum patterns created with if statements
  • c7b9dc4: 8328404: RISC-V: Fix potential crash in C2_MacroAssembler::arrays_equals
  • bc73963: 8328303: 3 JDI tests timed out with UT enabled
  • ... and 6 more: https://git.openjdk.org/jdk/compare/4d932d615c78f45516a4f136398e7610546065a6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Mar 22, 2024

@rhalade The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label Mar 22, 2024
@rhalade rhalade changed the title Googles CAInterop test failures 8328825: Googles CAInterop test failures Mar 22, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 22, 2024
@rhalade rhalade changed the title 8328825: Googles CAInterop test failures 8328825: Google CAInterop test failures Mar 22, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 22, 2024

Webrevs

Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable. I checked that tests for these certificates are now passing.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 25, 2024
@rhalade
Copy link
Member Author

rhalade commented Mar 25, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Mar 25, 2024

Going to push as commit 70a15c7.
Since your change was applied there have been 22 commits pushed to the master branch:

  • a1fbbff: 8328717: Convert javax/swing/JColorChooser/8065098/bug8065098.java applet test to main
  • 26b2ec4: 8328824: Clean up java.base native compilation
  • af15c68: 8321278: C2: Partial peeling fails with assert "last_peel <- first_not_peeled"
  • 142c311: 8328744: Parallel: Parallel GC throws OOM before heap is fully expanded
  • cb2a671: 8324121: SIGFPE in PhaseIdealLoop::extract_long_range_checks
  • 0c1b254: 8326438: C2: assert(ld->in(1)->Opcode() == Op_LoadN) failed: Assumption invalid: input to DecodeN is not LoadN
  • 29ba4b7: 8328705: GHA: Cross-compilation jobs do not require build JDK
  • f67ec19: 8079786: [macosx] Test java/awt/Frame/DisposeParentGC/DisposeParentGC.java fails for Mac only
  • 93579c2: 8323552: AbstractMemorySegmentImpl#mismatch returns -1 when comparing distinct areas of the same instance of MemorySegment
  • b235682: 8328709: AIX os::get_summary_cpu_info support Power 10
  • ... and 12 more: https://git.openjdk.org/jdk/compare/4d932d615c78f45516a4f136398e7610546065a6...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 25, 2024
@openjdk openjdk bot closed this Mar 25, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 25, 2024
@openjdk
Copy link

openjdk bot commented Mar 25, 2024

@rhalade Pushed as commit 70a15c7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@rhalade rhalade deleted the 8328825-google-cacissue branch March 25, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated security security-dev@openjdk.org
2 participants