8328744: Parallel: Parallel GC throws OOM before heap is fully expanded

[zhengyu123]

Parallel Scavenge may give up if it determines that current old gen does not have enough free space to accommodate estimated promotion size, and fall back to compact GC.

If compact GC can not reclaim enough space, this vicious cycle continues until OOM, without any intentions to expand old gen. We saw our production instances running hundreds compact GCs, while heaps were not fully utilized.

I believe when Scavenge determines if there is enough old space for the promotion, it should also consider the free space may be created by expanding the old gen.

Tests:
hotspot_gc, tier1 and tier2 with Parallel GC (fastdebug and release) on x86_64 and MacOSX

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8328744: Parallel: Parallel GC throws OOM before heap is fully expanded (Bug - P2)

Reviewers

• Albert Mingkun Yang (@albertnetymk - Reviewer)
• Thomas Schatzl (@tschatzl - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18463/head:pull/18463
$ git checkout pull/18463

Update a local copy of the PR:
$ git checkout pull/18463
$ git pull https://git.openjdk.org/jdk.git pull/18463/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18463

View PR using the GUI difftool:
$ git pr show -t 18463

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18463.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@zhengyu123 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8328744: Parallel: Parallel GC throws OOM before heap is fully expanded

Reviewed-by: ayang, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

• 0c1b254: 8326438: C2: assert(ld->in(1)->Opcode() == Op_LoadN) failed: Assumption invalid: input to DecodeN is not LoadN
• 29ba4b7: 8328705: GHA: Cross-compilation jobs do not require build JDK
• f67ec19: 8079786: [macosx] Test java/awt/Frame/DisposeParentGC/DisposeParentGC.java fails for Mac only
• 93579c2: 8323552: AbstractMemorySegmentImpl#mismatch returns -1 when comparing distinct areas of the same instance of MemorySegment
• b235682: 8328709: AIX os::get_summary_cpu_info support Power 10
• 19a0151: 8328700: Unused import and variable should be deleted in regex package
• cf9b5a7: 8328776: [AIX] remove checked_vmgetinfo, use vmgetinfo directly
• acc4a82: 8328862: Remove unused GrowableArrayFilterIterator
• 9f920b9: 8324655: Identify integer minimum and maximum patterns created with if statements
• c7b9dc4: 8328404: RISC-V: Fix potential crash in C2_MacroAssembler::arrays_equals
• ... and 4 more: https://git.openjdk.org/jdk/compare/4324e3be9ea8233b3625440330b9e8a269672f85...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@zhengyu123 The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (b9fd5a96)

[zhengyu123]

Thanks for the reviews, @albertnetymk @tschatzl

[zhengyu123]

/integrate

[openjdk]

Going to push as commit 142c311.
Since your change was applied there have been 15 commits pushed to the master branch:

• cb2a671: 8324121: SIGFPE in PhaseIdealLoop::extract_long_range_checks
• 0c1b254: 8326438: C2: assert(ld->in(1)->Opcode() == Op_LoadN) failed: Assumption invalid: input to DecodeN is not LoadN
• 29ba4b7: 8328705: GHA: Cross-compilation jobs do not require build JDK
• f67ec19: 8079786: [macosx] Test java/awt/Frame/DisposeParentGC/DisposeParentGC.java fails for Mac only
• 93579c2: 8323552: AbstractMemorySegmentImpl#mismatch returns -1 when comparing distinct areas of the same instance of MemorySegment
• b235682: 8328709: AIX os::get_summary_cpu_info support Power 10
• 19a0151: 8328700: Unused import and variable should be deleted in regex package
• cf9b5a7: 8328776: [AIX] remove checked_vmgetinfo, use vmgetinfo directly
• acc4a82: 8328862: Remove unused GrowableArrayFilterIterator
• 9f920b9: 8324655: Identify integer minimum and maximum patterns created with if statements
• ... and 5 more: https://git.openjdk.org/jdk/compare/4324e3be9ea8233b3625440330b9e8a269672f85...master

Your commit was automatically rebased without conflicts.

[openjdk]

@zhengyu123 Pushed as commit 142c311.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[zhengyu123]

/backport jdk22u

[openjdk]

@zhengyu123 the backport was successfully created on the branch backport-zhengyu123-142c311e in my personal fork of openjdk/jdk22u. To create a pull request with this backport targeting openjdk/jdk22u:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 142c311e from the openjdk/jdk repository.

The commit being backported was authored by Zhengyu Gu on 25 Mar 2024 and was reviewed by Albert Mingkun Yang and Thomas Schatzl.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk22u:

$ git fetch https://github.com/openjdk-bots/jdk22u.git backport-zhengyu123-142c311e:backport-zhengyu123-142c311e
$ git checkout backport-zhengyu123-142c311e
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk22u.git backport-zhengyu123-142c311e

⚠️ @zhengyu123 You are not yet a collaborator in my fork openjdk-bots/jdk22u. An invite will be sent out and you need to accept it before you can proceed.

[zhengyu123]

/backport jdk17u

[openjdk]

@zhengyu123 Could not automatically backport 142c311e to openjdk/jdk17u due to conflicts in the following files:

• src/hotspot/share/gc/parallel/psScavenge.cpp

Please fetch the appropriate branch/commit and manually resolve these conflicts by using the following commands in your personal fork of openjdk/jdk17u. Note: these commands are just some suggestions and you can use other equivalent commands you know.

# Fetch the up-to-date version of the target branch
$ git fetch --no-tags https://git.openjdk.org/jdk17u.git master:master

# Check out the target branch and create your own branch to backport
$ git checkout master
$ git checkout -b backport-zhengyu123-142c311e

# Fetch the commit you want to backport
$ git fetch --no-tags https://git.openjdk.org/jdk.git 142c311e3b9bd3f00edaa6ba7bcbc9fc285ee9b9

# Backport the commit
$ git cherry-pick --no-commit 142c311e3b9bd3f00edaa6ba7bcbc9fc285ee9b9
# Resolve conflicts now

# Commit the files you have modified
$ git add files/with/resolved/conflicts
$ git commit -m 'Backport 142c311e3b9bd3f00edaa6ba7bcbc9fc285ee9b9'

Once you have resolved the conflicts as explained above continue with creating a pull request towards the openjdk/jdk17u with the title Backport 142c311e3b9bd3f00edaa6ba7bcbc9fc285ee9b9.

Below you can find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 142c311e from the openjdk/jdk repository.

The commit being backported was authored by Zhengyu Gu on 25 Mar 2024 and was reviewed by Albert Mingkun Yang and Thomas Schatzl.

Thanks!