-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8328948: GHA: Restoring sysroot from cache skips the build after JDK-8326960 #18475
8328948: GHA: Restoring sysroot from cache skips the build after JDK-8326960 #18475
Conversation
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
@shipilev This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 3 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
66b6dc2
to
93cca96
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks correct.
Second GHA run compiles cross-builds fully. I will integrate and backport this soon, so that we don't miss build failures in the interim. |
I am integrating without waiting for the rest of GHA to complete, in order to line up backports. /integrate |
Going to push as commit 447436e.
Your commit was automatically rebased without conflicts. |
When doing JDK-8326960, I missed the case when sysroot would be restored from the cache. This would skip the configure and build steps, because it would only consult the status for create-sysroot job. This is only a problem when PR gets tested the second time, the first time we would always create a sysroot. I only noticed this after merging the master into existing PRs.
This is a regression that might hide build issues on platforms, and so it should be fixed ASAP.
Additional testing:
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18475/head:pull/18475
$ git checkout pull/18475
Update a local copy of the PR:
$ git checkout pull/18475
$ git pull https://git.openjdk.org/jdk.git pull/18475/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 18475
View PR using the GUI difftool:
$ git pr show -t 18475
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18475.diff
Webrev
Link to Webrev Comment