Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8258736: No break in the loop #1848

Closed
wants to merge 2 commits into from
Closed

Conversation

@XueleiFan
Copy link
Member

@XueleiFan XueleiFan commented Dec 19, 2020

It looks like the break is missed in the loop of the SSLCipher.createReadCipher() and createWriteCipher() methods. See the change set.

Code cleanup, no new regression test.

Bug: https://bugs.openjdk.java.net/browse/JDK-8258736


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1848/head:pull/1848
$ git checkout pull/1848

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 19, 2020

👋 Welcome back xuelei! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Dec 19, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 19, 2020

@XueleiFan The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the security label Dec 19, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 19, 2020

Webrevs

Loading

Copy link
Contributor

@bradfordwetmore bradfordwetmore left a comment

Approved with the condition of updating the copyright year.

There was also a failure in the Linux Presubmit tests which is probably bogus.

Looks good otherwise.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Dec 21, 2020

@XueleiFan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8258736: No break in the loop

Reviewed-by: wetmore

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 27 new commits pushed to the master branch:

  • 01d51a1: 8231622: SuppressWarning("serial") ignored on field serialVersionUID
  • a06cea5: 8258396: SIGILL in jdk.jfr.internal.PlatformRecorder.rotateDisk()
  • d234388: Merge
  • e680ebe: 8258007: Add instrumentation to NativeLibraryTest
  • c04c7e1: 8258002: Update "type" terminology in generated docs
  • 45bd3b9: 8223607: --override-methods=summary ignores some signature changes
  • 59ae054: 8258687: Build broken on Windows after fix for JDK-8258134
  • 1cc98bd: 8256693: getAnnotatedReceiverType parameterizes types too eagerly
  • 1ce2e94: 8256843: [PPC64] runtime/logging/RedefineClasses.java fails with assert: registers not saved on stack
  • 45a150b: 8258134: assert(size == calc_size) failed: incorrect size calculation on x86_32 with AVX512 machines
  • ... and 17 more: https://git.openjdk.java.net/jdk/compare/be41468c838666ded51437226e3668bb45043205...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Dec 21, 2020
@XueleiFan
Copy link
Member Author

@XueleiFan XueleiFan commented Dec 21, 2020

Approved with the condition of updating the copyright year.

Good catch!

There was also a failure in the Linux Presubmit tests which is probably bogus.

I checked the failure, which is not related to this update.

Looks good otherwise.

Thanks for the review.

Loading

@XueleiFan XueleiFan closed this Dec 21, 2020
@XueleiFan
Copy link
Member Author

@XueleiFan XueleiFan commented Dec 21, 2020

/integrate

Loading

@openjdk openjdk bot added integrated and removed ready rfr labels Dec 21, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 21, 2020

@XueleiFan Since your change was applied there have been 27 commits pushed to the master branch:

  • 01d51a1: 8231622: SuppressWarning("serial") ignored on field serialVersionUID
  • a06cea5: 8258396: SIGILL in jdk.jfr.internal.PlatformRecorder.rotateDisk()
  • d234388: Merge
  • e680ebe: 8258007: Add instrumentation to NativeLibraryTest
  • c04c7e1: 8258002: Update "type" terminology in generated docs
  • 45bd3b9: 8223607: --override-methods=summary ignores some signature changes
  • 59ae054: 8258687: Build broken on Windows after fix for JDK-8258134
  • 1cc98bd: 8256693: getAnnotatedReceiverType parameterizes types too eagerly
  • 1ce2e94: 8256843: [PPC64] runtime/logging/RedefineClasses.java fails with assert: registers not saved on stack
  • 45a150b: 8258134: assert(size == calc_size) failed: incorrect size calculation on x86_32 with AVX512 machines
  • ... and 17 more: https://git.openjdk.java.net/jdk/compare/be41468c838666ded51437226e3668bb45043205...master

Your commit was automatically rebased without conflicts.

Pushed as commit 12297a0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@XueleiFan XueleiFan deleted the JDK-8258736 branch Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants