Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8328997: Remove unnecessary template parameter lists in GrowableArray #18480

Closed
wants to merge 1 commit into from

Conversation

kimbarrett
Copy link

@kimbarrett kimbarrett commented Mar 25, 2024

Please review this change to the GrowableArray code to remove unnecessary
template parameter lists. They aren't needed, and some may become
syntactically invalid in the future.

Testing: mach5 tier1.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8328997: Remove unnecessary template parameter lists in GrowableArray (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18480/head:pull/18480
$ git checkout pull/18480

Update a local copy of the PR:
$ git checkout pull/18480
$ git pull https://git.openjdk.org/jdk.git pull/18480/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18480

View PR using the GUI difftool:
$ git pr show -t 18480

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18480.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 25, 2024

👋 Welcome back kbarrett! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 25, 2024

@kimbarrett This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8328997: Remove unnecessary template parameter lists in GrowableArray

Reviewed-by: iwalulya, epeter

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 86 new commits pushed to the master branch:

  • 5cddc2d: 8325252: C2 SuperWord: refactor the packset
  • 6b1b0e9: 8329103: assert(!thread->in_asgct()) failed during multi-mode profiling
  • bc546c2: 8328561: test java/awt/Robot/ManualInstructions/ManualInstructions.java isn't used
  • af7c6af: 8324808: Manual printer tests have no Pass/Fail buttons, instructions close set 3
  • d3fc8df: 8329135: Store Universe::*exception_instance() in CDS archive
  • a85c849: 8328273: sun/management/jmxremote/bootstrap/RmiRegistrySslTest.java failed with java.rmi.server.ExportException: Port already in use
  • 70c8ff1: 8328665: serviceability/jvmti/vthread/PopFrameTest failed with a timeout
  • ecd2b71: 8329354: java/text/Format/MessageFormat/CompactSubFormats.java fails
  • c2979c1: 8329425: ProblemList containers/docker/TestJFREvents.java on linux-x64
  • 5698f7a: 8329134: Reconsider TLAB zapping
  • ... and 76 more: https://git.openjdk.org/jdk/compare/acc4a828184bd2838a5c0b572f404aa1edaf59e2...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 25, 2024
@openjdk
Copy link

openjdk bot commented Mar 25, 2024

@kimbarrett The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Mar 25, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 26, 2024

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 26, 2024
Copy link
Contributor

@eme64 eme64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable :)

@kimbarrett
Copy link
Author

Thanks for reviews @walulyai and @eme64 .

@kimbarrett
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 2, 2024

Going to push as commit 3d22838.
Since your change was applied there have been 86 commits pushed to the master branch:

  • 5cddc2d: 8325252: C2 SuperWord: refactor the packset
  • 6b1b0e9: 8329103: assert(!thread->in_asgct()) failed during multi-mode profiling
  • bc546c2: 8328561: test java/awt/Robot/ManualInstructions/ManualInstructions.java isn't used
  • af7c6af: 8324808: Manual printer tests have no Pass/Fail buttons, instructions close set 3
  • d3fc8df: 8329135: Store Universe::*exception_instance() in CDS archive
  • a85c849: 8328273: sun/management/jmxremote/bootstrap/RmiRegistrySslTest.java failed with java.rmi.server.ExportException: Port already in use
  • 70c8ff1: 8328665: serviceability/jvmti/vthread/PopFrameTest failed with a timeout
  • ecd2b71: 8329354: java/text/Format/MessageFormat/CompactSubFormats.java fails
  • c2979c1: 8329425: ProblemList containers/docker/TestJFREvents.java on linux-x64
  • 5698f7a: 8329134: Reconsider TLAB zapping
  • ... and 76 more: https://git.openjdk.org/jdk/compare/acc4a828184bd2838a5c0b572f404aa1edaf59e2...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 2, 2024
@openjdk openjdk bot closed this Apr 2, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 2, 2024
@openjdk
Copy link

openjdk bot commented Apr 2, 2024

@kimbarrett Pushed as commit 3d22838.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kimbarrett kimbarrett deleted the ga-specs branch April 2, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants