Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8327493: Update minimum Xcode version in docs #18483

Closed
wants to merge 1 commit into from

Conversation

magicus
Copy link
Member

@magicus magicus commented Mar 26, 2024

The file building.{md,html} indicates the required minimum version of Xcode to use. When the required minimum version of Clang was updated to 13 (JDK-8325878), the minimum Xcode version was not updated. It should now be Xcode 13.0, rather than 8.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8327493: Update minimum Xcode version in docs (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18483/head:pull/18483
$ git checkout pull/18483

Update a local copy of the PR:
$ git checkout pull/18483
$ git pull https://git.openjdk.org/jdk.git pull/18483/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18483

View PR using the GUI difftool:
$ git pr show -t 18483

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18483.diff

Webrev

Link to Webrev Comment

@magicus
Copy link
Member Author

magicus commented Mar 26, 2024

/integrate auto

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 26, 2024

👋 Welcome back ihse! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 26, 2024

@magicus This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8327493: Update minimum Xcode version in docs

Reviewed-by: clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added rfr Pull request is ready for review auto labels Mar 26, 2024
@openjdk
Copy link

openjdk bot commented Mar 26, 2024

@magicus This pull request will be automatically integrated when it is ready

@openjdk
Copy link

openjdk bot commented Mar 26, 2024

@magicus The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build build-dev@openjdk.org label Mar 26, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 26, 2024

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 26, 2024
@openjdk
Copy link

openjdk bot commented Mar 26, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Mar 26, 2024

Going to push as commit 7b1f2c8.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 26, 2024
@openjdk openjdk bot closed this Mar 26, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 26, 2024
@openjdk
Copy link

openjdk bot commented Mar 26, 2024

@openjdk[bot] Pushed as commit 7b1f2c8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@magicus magicus deleted the update-xcode-docs branch March 26, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto build build-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants