8258662: JDK 17ea: Crash compiling instanceof check involving sealed interface

[lgxbslgx]

Hi all,

The method Types.isCastable uses method Types.areDisjoint to do some check. But Types.isCastable doesn't check the type of the parameter before invoking method Types.areDisjoint. This patch adds the corresponding check and add a test case.

Thank you for taking the time to review.

Best Regards.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8258662: JDK 17ea: Crash compiling instanceof check involving sealed interface

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1849/head:pull/1849
$ git checkout pull/1849

[bridgekeeper]

👋 Welcome back lgxbslgx! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@lgxbslgx The following label will be automatically applied to this pull request:

• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (3b77d03)
• 00: Full (41e94f2)

[jonathan-gibbons]

In general, the coding style in javac is to use methods and/or the kind to determine whether is symbol is the symbol for a class or not.

I'll leave it to others to recommend the current best practice for a change like this.

[vicente-romero-oracle]

the fix looks good to me but we need this code in JDK 16, please create another PR targeting JDK 16 and close this one. Thanks for the fix!

[lgxbslgx]

Move it to JDK 16. Please see openjdk/jdk16#63.