New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8257809: JNI warnings from Toolkit JPEG image decoding #1850
Conversation
👋 Welcome back prr! A progress list of the required criteria for merging this PR into |
$TESTJAVA/bin/java ${TESTVMOPTS} \ | ||
-cp "${CP}" -Xcheck:jni GetImageJNICheck | grep ReleasePrimitiveArrayCritical > "${CP}"/log.txt | ||
|
||
#if [ $? -ne 0 ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I always wonder why it is not possible to report such warnings as fatal errors or at least report the exit code as non zero. Probably it is meant to create an enhancement?
@prrace This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 61 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
@prrace Since your change was applied there have been 87 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit e6f9926. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
The fix is to reverse the order of acquisition to get dst before src so that the call to GetArrayLength() comes first.
This also necessitates moving the RELEASE_ARRAYS() call on an error condition to the new "2nd" block.
The new regression test passes on all platforms and all the other headless tests passed too.
So do the automated headful tests.
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/1850/head:pull/1850
$ git checkout pull/1850