Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8257809: JNI warnings from Toolkit JPEG image decoding #1850

Closed
wants to merge 2 commits into from
Closed

8257809: JNI warnings from Toolkit JPEG image decoding #1850

wants to merge 2 commits into from

Conversation

@prrace
Copy link
Contributor

@prrace prrace commented Dec 20, 2020

The fix is to reverse the order of acquisition to get dst before src so that the call to GetArrayLength() comes first.
This also necessitates moving the RELEASE_ARRAYS() call on an error condition to the new "2nd" block.

The new regression test passes on all platforms and all the other headless tests passed too.
So do the automated headful tests.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8257809: JNI warnings from Toolkit JPEG image decoding

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1850/head:pull/1850
$ git checkout pull/1850

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 20, 2020

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Dec 20, 2020

@prrace The following labels will be automatically applied to this pull request:

  • 2d
  • awt
  • swing

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr label Dec 20, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 20, 2020

Webrevs

mrserb
mrserb approved these changes Dec 23, 2020
$TESTJAVA/bin/java ${TESTVMOPTS} \
-cp "${CP}" -Xcheck:jni GetImageJNICheck | grep ReleasePrimitiveArrayCritical > "${CP}"/log.txt

#if [ $? -ne 0 ]
Copy link
Member

@mrserb mrserb Dec 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always wonder why it is not possible to report such warnings as fatal errors or at least report the exit code as non zero. Probably it is meant to create an enhancement?

@openjdk
Copy link

@openjdk openjdk bot commented Dec 23, 2020

@prrace This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8257809: JNI warnings from Toolkit JPEG image decoding

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 61 new commits pushed to the master branch:

  • fda0943: 8258839: Remove JVM option ExitVMOnVerifyError
  • cd94606: 8258186: Replace use of JNI_COMMIT mode with mode 0
  • e46edb5: 8258911: ProblemList serviceability/attach/RemovingUnixDomainSocketTest.java on Linux-X64
  • 91244cc: 8258557: Deproblemlist fixed problemlisted test
  • 2445735: 8258837: Remove JVM option DisableStartThread
  • a4e082e: 8253368: TLS connection always receives close_notify exception
  • 4ea8851: 8257928: Test image build failure with clang-10 due to -Wmisleading-indentation
  • f2bad3a: Merge
  • 61e5e39: 8258832: ProblemList com/sun/jdi/AfterThreadDeathTest.java on Linux-X64
  • eabc903: 8258827: ProblemList Naming/DefaultRegistryPort.java and Naming/legalRegistryNames/LegalRegistryNames.java on Windows
  • ... and 51 more: https://git.openjdk.java.net/jdk/compare/3f77a6002ea7c150308409600abd4f1140bfb36a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Dec 23, 2020
@prrace
Copy link
Contributor Author

@prrace prrace commented Jan 4, 2021

/integrate

@openjdk openjdk bot closed this Jan 4, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jan 4, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 4, 2021

@prrace Since your change was applied there have been 87 commits pushed to the master branch:

  • 9d160aa: 8257815: Replace global log2 functions with efficient implementations
  • f80c63b: 8258490: Shenandoah: Full GC does not need to remark threads and drain SATB buffers
  • 7f04d23: 8258800: Deprecate -XX:+AlwaysLockClassLoader
  • d679caa: 8196466: javax/swing/JFileChooser/8062561/bug8062561.java fails
  • a2a3f4a: 8258924: javax/swing/JSplitPane/4201995/bug4201995.java fails in GTk L&F
  • f351e15: 8258382: Fix optimization-unstable code involving pointer overflow
  • 526c000: 8255729: com.sun.tools.javac.processing.JavacFiler.FilerOutputStream is inefficient
  • 497efef: 8225116: Test OwnedWindowsLeak.java intermittently fails
  • f5ee356: 8179503: Java should support GET OCSP calls
  • 8435f0d: 8258525: Some existing tests should use /nodynamiccopyright/ instead of the standard header
  • ... and 77 more: https://git.openjdk.java.net/jdk/compare/3f77a6002ea7c150308409600abd4f1140bfb36a...master

Your commit was automatically rebased without conflicts.

Pushed as commit e6f9926.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@prrace prrace deleted the critical branch Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants