/ jdk Public
8257809: JNI warnings from Toolkit JPEG image decoding #1850
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
The fix is to reverse the order of acquisition to get dst before src so that the call to GetArrayLength() comes first.
This also necessitates moving the RELEASE_ARRAYS() call on an error condition to the new "2nd" block.
The new regression test passes on all platforms and all the other headless tests passed too.
So do the automated headful tests.
$ git fetch https://git.openjdk.java.net/jdk pull/1850/head:pull/1850
$ git checkout pull/1850