8329163: C2: possible overflow in PhaseIdealLoop::extract_long_range_checks()

[rwestrel]

This change avoids the overflow of ABS(scale) when scale is min_jlong.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8329163: C2: possible overflow in PhaseIdealLoop::extract_long_range_checks() (Bug - P4)

Reviewers

• Christian Hagedorn (@chhagedorn - Reviewer)
• Vladimir Kozlov (@vnkozlov - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18508/head:pull/18508
$ git checkout pull/18508

Update a local copy of the PR:
$ git checkout pull/18508
$ git pull https://git.openjdk.org/jdk.git pull/18508/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18508

View PR using the GUI difftool:
$ git pr show -t 18508

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18508.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back roland! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@rwestrel This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8329163: C2: possible overflow in PhaseIdealLoop::extract_long_range_checks()

Reviewed-by: chagedorn, kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

• 614db2e: 8328638: Fallback option for POST-only OCSP requests
• d292aab: 8329086: Clean up java.desktop native compilation
• d0a2650: 8324774: Add DejaVu web fonts
• 37a5a08: 8329102: Clean up jdk.jpackage native compilation
• 788d2bc: 8329169: Parallel: Remove unused local variable in MutableSpace::print_on
• 4dfcc6d: 8329115: Crash involving return from inner switch
• 9e566d7: 8327971: Multiple ASAN errors reported for metaspace
• 8fc9097: 8315575: Retransform of record class with record component annotation fails with CFE
• 2725405: 8327991: Improve HttpClient documentation with regard to reclaiming resources
• db01fcd: 8328827: Convert java/awt/print/PrinterJob/PrinterDialogsModalityTest/PrinterDialogsModalityTest.html applet test to main
• ... and 8 more: https://git.openjdk.org/jdk/compare/44549b605a7aad1e3143a4058ef6504a7c04167a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@rwestrel The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (94eb61f2)

[chhagedorn]

Looks good!

[vnkozlov]

Good.

[rwestrel]

Thanks for the reviews @chhagedorn @vnkozlov

[rwestrel]

/integrate

[openjdk]

Going to push as commit 05854fd.
Since your change was applied there have been 18 commits pushed to the master branch:

• 614db2e: 8328638: Fallback option for POST-only OCSP requests
• d292aab: 8329086: Clean up java.desktop native compilation
• d0a2650: 8324774: Add DejaVu web fonts
• 37a5a08: 8329102: Clean up jdk.jpackage native compilation
• 788d2bc: 8329169: Parallel: Remove unused local variable in MutableSpace::print_on
• 4dfcc6d: 8329115: Crash involving return from inner switch
• 9e566d7: 8327971: Multiple ASAN errors reported for metaspace
• 8fc9097: 8315575: Retransform of record class with record component annotation fails with CFE
• 2725405: 8327991: Improve HttpClient documentation with regard to reclaiming resources
• db01fcd: 8328827: Convert java/awt/print/PrinterJob/PrinterDialogsModalityTest/PrinterDialogsModalityTest.html applet test to main
• ... and 8 more: https://git.openjdk.org/jdk/compare/44549b605a7aad1e3143a4058ef6504a7c04167a...master

Your commit was automatically rebased without conflicts.

[openjdk]

@rwestrel Pushed as commit 05854fd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.