8329191: JVMCI compiler warning is truncated

[dougxc]

$ java -Djdk.graal.CompilerConfiguration=XXcommunity HelloWorld
[0.035s][warning][jit,compilation] JVMCI compiler disabled after 11 of 11 upcalls had errors (Last error: "uncaught exception in call_HotSpotJVMCIRuntime_compileMethod [jdk.graal.compiler.debug.GraalError: Compiler configuration 'XXcommunity' not found. Available configurations are: enterp

The above message is truncated. It should be:

[0.032s][warning][jit,compilation] JVMCI compiler disabled after 11 of 11 upcalls had errors (Last error: "uncaught exception in call_HotSpotJVMCIRuntime_compileMethod [jdk.graal.compiler.debug.GraalError: Compiler configuration 'XXcommunity' not found. Available configurations are: enterprise, community, economy]"). Use -Xlog:jit+compilation for more detail.

This PR fixes this by using stringStream instead of err_msg when creating these messages.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8329191: JVMCI compiler warning is truncated (Bug - P4)

Reviewers

• Tom Rodriguez (@tkrodriguez - Reviewer)
• @fniephaus (no known openjdk.org user name / role)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18513/head:pull/18513
$ git checkout pull/18513

Update a local copy of the PR:
$ git checkout pull/18513
$ git pull https://git.openjdk.org/jdk.git pull/18513/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18513

View PR using the GUI difftool:
$ git pr show -t 18513

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18513.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dnsimon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@dougxc This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8329191: JVMCI compiler warning is truncated

Reviewed-by: never

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

• 47f33a5: 8327986: ASAN reports use-after-free in DirectivesParserTest.empty_object_vm
• d580bcf: 8329178: Clean up jdk.accessibility native compilation
• 4fa77a2: 8329096: G1: Change the type of G1BlockOffsetTable::_offset_base to uint8_t*
• 3eb1d05: 8328986: Deprecate UseRTM* flags for removal
• 0cb0b5d: 8327875: ChoiceFormat should advise throwing UnsupportedOperationException for unused methods
• e3588bb: 8328819: Remove applet usage from JFileChooser tests bug6698013
• cc5b9c6: 8328227: Remove applet usage from JColorChooser tests Test4887836
• 892b8bb: 8329189: runtime/stack/Stack016.java fails on libgraal
• 05854fd: 8329163: C2: possible overflow in PhaseIdealLoop::extract_long_range_checks()
• 614db2e: 8328638: Fallback option for POST-only OCSP requests
• ... and 1 more: https://git.openjdk.org/jdk/compare/d0a265039a36292d87b249af0e8977982e5acc7b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@dougxc The following labels will be automatically applied to this pull request:

• graal
• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (61d6486d)
• 00: Full (5f23d0e7)

[tkrodriguez]

In jvmciEnv.cpp were use err_msg with _init_error_msg in two places. Should those also use stringStream? All the other uses of err_msg look like they should be short enough to use the preallocated buffer.

[tkrodriguez]

looks good.

[dougxc]

Thanks for the reviews.

/integrate

[openjdk]

Going to push as commit 7c7b961.
Since your change was applied there have been 12 commits pushed to the master branch:

• 2b79c22: 8327505: Test com/sun/jmx/remote/NotificationMarshalVersions/TestSerializationMismatch.java fails
• 47f33a5: 8327986: ASAN reports use-after-free in DirectivesParserTest.empty_object_vm
• d580bcf: 8329178: Clean up jdk.accessibility native compilation
• 4fa77a2: 8329096: G1: Change the type of G1BlockOffsetTable::_offset_base to uint8_t*
• 3eb1d05: 8328986: Deprecate UseRTM* flags for removal
• 0cb0b5d: 8327875: ChoiceFormat should advise throwing UnsupportedOperationException for unused methods
• e3588bb: 8328819: Remove applet usage from JFileChooser tests bug6698013
• cc5b9c6: 8328227: Remove applet usage from JColorChooser tests Test4887836
• 892b8bb: 8329189: runtime/stack/Stack016.java fails on libgraal
• 05854fd: 8329163: C2: possible overflow in PhaseIdealLoop::extract_long_range_checks()
• ... and 2 more: https://git.openjdk.org/jdk/compare/d0a265039a36292d87b249af0e8977982e5acc7b...master

Your commit was automatically rebased without conflicts.

[openjdk]

@dougxc Pushed as commit 7c7b961.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.