-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8329210: Delete Redundant Printer Dialog Modality Test #18524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back dnguyen! A progress list of the required criteria for merging this PR into |
|
@DamonGuy This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 22 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
honkar-jdk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
/integrate |
|
Going to push as commit 7ac2f91.
Your commit was automatically rebased without conflicts. |
test/jdk/java/awt/print/Dialog/PrintModalDialog.java is too similar in functionality to test/jdk/java/awt/print/PrinterJob/PrinterDialogsModalityTest.java.
One test was originally for modality in web browsers, while the other was for modality in Windows OS printer dialogs, but after the updates, they both check for modality on print and page dialogs for all OSs.
Since PrinterDialogsModalityTest.java is the preferred test, this is to remove PrintModalDialog.java as a test. In addition, the bugID in the jtreg tags from PrintModalDialog.java will be added to PrinterDialogsModalityTest.java's tags to maintain a link to its original bug.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18524/head:pull/18524$ git checkout pull/18524Update a local copy of the PR:
$ git checkout pull/18524$ git pull https://git.openjdk.org/jdk.git pull/18524/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 18524View PR using the GUI difftool:
$ git pr show -t 18524Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18524.diff
Webrev
Link to Webrev Comment