Skip to content

Conversation

@DamonGuy
Copy link
Contributor

@DamonGuy DamonGuy commented Mar 27, 2024

test/jdk/java/awt/print/Dialog/PrintModalDialog.java is too similar in functionality to test/jdk/java/awt/print/PrinterJob/PrinterDialogsModalityTest.java.

One test was originally for modality in web browsers, while the other was for modality in Windows OS printer dialogs, but after the updates, they both check for modality on print and page dialogs for all OSs.

Since PrinterDialogsModalityTest.java is the preferred test, this is to remove PrintModalDialog.java as a test. In addition, the bugID in the jtreg tags from PrintModalDialog.java will be added to PrinterDialogsModalityTest.java's tags to maintain a link to its original bug.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8329210: Delete Redundant Printer Dialog Modality Test (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18524/head:pull/18524
$ git checkout pull/18524

Update a local copy of the PR:
$ git checkout pull/18524
$ git pull https://git.openjdk.org/jdk.git pull/18524/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18524

View PR using the GUI difftool:
$ git pr show -t 18524

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18524.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 27, 2024

👋 Welcome back dnguyen! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 27, 2024

@DamonGuy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8329210: Delete Redundant Printer Dialog Modality Test

Reviewed-by: honkar, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 22 new commits pushed to the master branch:

  • 85cb4a9: 8247449: Revisit the argument processing logic for MetaspaceShared::disable_optimized_module_handling()
  • aa595db: 8328507: Move StackWatermark code from safepoint cleanup
  • 2af0312: 8328619: sun/management/jmxremote/bootstrap/SSLConfigFilePermissionTest.java failed with BindException: Address already in use
  • 7c7b961: 8329191: JVMCI compiler warning is truncated
  • 2b79c22: 8327505: Test com/sun/jmx/remote/NotificationMarshalVersions/TestSerializationMismatch.java fails
  • 47f33a5: 8327986: ASAN reports use-after-free in DirectivesParserTest.empty_object_vm
  • d580bcf: 8329178: Clean up jdk.accessibility native compilation
  • 4fa77a2: 8329096: G1: Change the type of G1BlockOffsetTable::_offset_base to uint8_t*
  • 3eb1d05: 8328986: Deprecate UseRTM* flags for removal
  • 0cb0b5d: 8327875: ChoiceFormat should advise throwing UnsupportedOperationException for unused methods
  • ... and 12 more: https://git.openjdk.org/jdk/compare/2725405ac9d93761e26812d010d315a48f86071c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 27, 2024
@openjdk
Copy link

openjdk bot commented Mar 27, 2024

@DamonGuy The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Mar 27, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 27, 2024

Webrevs

Copy link
Contributor

@honkar-jdk honkar-jdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 27, 2024
@DamonGuy
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 28, 2024

Going to push as commit 7ac2f91.
Since your change was applied there have been 22 commits pushed to the master branch:

  • 85cb4a9: 8247449: Revisit the argument processing logic for MetaspaceShared::disable_optimized_module_handling()
  • aa595db: 8328507: Move StackWatermark code from safepoint cleanup
  • 2af0312: 8328619: sun/management/jmxremote/bootstrap/SSLConfigFilePermissionTest.java failed with BindException: Address already in use
  • 7c7b961: 8329191: JVMCI compiler warning is truncated
  • 2b79c22: 8327505: Test com/sun/jmx/remote/NotificationMarshalVersions/TestSerializationMismatch.java fails
  • 47f33a5: 8327986: ASAN reports use-after-free in DirectivesParserTest.empty_object_vm
  • d580bcf: 8329178: Clean up jdk.accessibility native compilation
  • 4fa77a2: 8329096: G1: Change the type of G1BlockOffsetTable::_offset_base to uint8_t*
  • 3eb1d05: 8328986: Deprecate UseRTM* flags for removal
  • 0cb0b5d: 8327875: ChoiceFormat should advise throwing UnsupportedOperationException for unused methods
  • ... and 12 more: https://git.openjdk.org/jdk/compare/2725405ac9d93761e26812d010d315a48f86071c...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 28, 2024
@openjdk openjdk bot closed this Mar 28, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 28, 2024
@openjdk
Copy link

openjdk bot commented Mar 28, 2024

@DamonGuy Pushed as commit 7ac2f91.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client client-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants