Skip to content

8236736: Change notproduct JVM flags to develop flags #18541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

8236736: Change notproduct JVM flags to develop flags #18541

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b32fbf7
8236736: Change notproduct JVM flags to develop flags
coleenp Mar 28, 2024
c3d9a1c
Missed one.
coleenp Mar 29, 2024
19b8f6b
Clean up notproduct from tests.
coleenp Apr 2, 2024
00a241d
Fix a couple issues pointed out by Stefank.
coleenp Apr 2, 2024
3b5002d
Remove redundant test case.
coleenp Apr 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/hotspot/cpu/aarch64/globals_aarch64.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,6 @@ define_pd_global(intx, InlineSmallCode, 1000);

#define ARCH_FLAGS(develop, \
product, \
notproduct, \
range, \
constraint) \
\
Expand Down
3 changes: 1 addition & 2 deletions src/hotspot/cpu/arm/globals_arm.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2008, 2023, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2008, 2024, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
Expand Down Expand Up @@ -75,7 +75,6 @@ define_pd_global(intx, InitArrayShortSize, 8*BytesPerLong);

#define ARCH_FLAGS(develop, \
product, \
notproduct, \
range, \
constraint)

Expand Down
3 changes: 1 addition & 2 deletions src/hotspot/cpu/ppc/globals_ppc.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2002, 2023, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2002, 2024, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2012, 2023 SAP SE. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
Expand Down Expand Up @@ -80,7 +80,6 @@ define_pd_global(intx, InitArrayShortSize, 9*BytesPerLong);
// Platform dependent flag handling: flags only defined on this platform.
#define ARCH_FLAGS(develop, \
product, \
notproduct, \
range, \
constraint) \
\
Expand Down
3 changes: 1 addition & 2 deletions src/hotspot/cpu/riscv/globals_riscv.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2000, 2023, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2000, 2024, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2020, 2023, Huawei Technologies Co., Ltd. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
Expand Down Expand Up @@ -78,7 +78,6 @@ define_pd_global(intx, InlineSmallCode, 1000);

#define ARCH_FLAGS(develop, \
product, \
notproduct, \
range, \
constraint) \
\
Expand Down
3 changes: 1 addition & 2 deletions src/hotspot/cpu/s390/globals_s390.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2016, 2023, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2016, 2024, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2016, 2018 SAP SE. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
Expand Down Expand Up @@ -80,7 +80,6 @@ define_pd_global(intx, InitArrayShortSize, 1*BytesPerLong);

#define ARCH_FLAGS(develop, \
product, \
notproduct, \
range, \
constraint) \
\
Expand Down
3 changes: 1 addition & 2 deletions src/hotspot/cpu/x86/globals_x86.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2000, 2023, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2000, 2024, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
Expand Down Expand Up @@ -98,7 +98,6 @@ define_pd_global(intx, InitArrayShortSize, 8*BytesPerLong);

#define ARCH_FLAGS(develop, \
product, \
notproduct, \
range, \
constraint) \
\
Expand Down
3 changes: 1 addition & 2 deletions src/hotspot/cpu/zero/globals_zero.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2000, 2023, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2000, 2024, Oracle and/or its affiliates. All rights reserved.
* Copyright 2007, 2008, 2009, 2010, 2011 Red Hat, Inc.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
Expand Down Expand Up @@ -77,7 +77,6 @@ define_pd_global(bool, CompactStrings, true);

#define ARCH_FLAGS(develop, \
product, \
notproduct, \
range, \
constraint) \
\
Expand Down
1 change: 0 additions & 1 deletion src/hotspot/os/aix/globals_aix.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@
develop_pd, \
product, \
product_pd, \
notproduct, \
range, \
constraint) \
\
Expand Down
3 changes: 1 addition & 2 deletions src/hotspot/os/bsd/globals_bsd.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2005, 2020, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2005, 2024, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
Expand Down Expand Up @@ -32,7 +32,6 @@
develop_pd, \
product, \
product_pd, \
notproduct, \
range, \
constraint) \
\
Expand Down
3 changes: 1 addition & 2 deletions src/hotspot/os/linux/globals_linux.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2005, 2022, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2005, 2024, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
Expand Down Expand Up @@ -32,7 +32,6 @@
develop_pd, \
product, \
product_pd, \
notproduct, \
range, \
constraint) \
\
Expand Down
3 changes: 1 addition & 2 deletions src/hotspot/os/windows/globals_windows.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2005, 2020, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2005, 2024, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
Expand Down Expand Up @@ -32,7 +32,6 @@
develop_pd, \
product, \
product_pd, \
notproduct, \
range, \
constraint) \
\
Expand Down
31 changes: 15 additions & 16 deletions src/hotspot/share/c1/c1_globals.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,48 +35,47 @@
develop_pd, \
product, \
product_pd, \
notproduct, \
range, \
constraint) \
\
/* Printing */ \
notproduct(bool, PrintC1Statistics, false, \
develop(bool, PrintC1Statistics, false, \
"Print Compiler1 statistics" ) \
\
notproduct(bool, PrintInitialBlockList, false, \
develop(bool, PrintInitialBlockList, false, \
"Print block list of BlockListBuilder") \
\
notproduct(bool, PrintCFG, false, \
develop(bool, PrintCFG, false, \
"Print control flow graph after each change") \
\
notproduct(bool, PrintCFG0, false, \
develop(bool, PrintCFG0, false, \
"Print control flow graph after construction") \
\
notproduct(bool, PrintCFG1, false, \
develop(bool, PrintCFG1, false, \
"Print control flow graph after optimizations") \
\
notproduct(bool, PrintCFG2, false, \
develop(bool, PrintCFG2, false, \
"Print control flow graph before code generation") \
\
notproduct(bool, PrintIRDuringConstruction, false, \
develop(bool, PrintIRDuringConstruction, false, \
"Print IR as it's being constructed (helpful for debugging frontend)")\
\
notproduct(bool, PrintPhiFunctions, false, \
develop(bool, PrintPhiFunctions, false, \
"Print phi functions when they are created and simplified") \
\
notproduct(bool, PrintIR, false, \
develop(bool, PrintIR, false, \
"Print full intermediate representation after each change") \
\
notproduct(bool, PrintIR0, false, \
develop(bool, PrintIR0, false, \
"Print full intermediate representation after construction") \
\
notproduct(bool, PrintIR1, false, \
develop(bool, PrintIR1, false, \
"Print full intermediate representation after optimizations") \
\
notproduct(bool, PrintIR2, false, \
develop(bool, PrintIR2, false, \
"Print full intermediate representation before code generation") \
\
notproduct(bool, PrintSimpleStubs, false, \
develop(bool, PrintSimpleStubs, false, \
"Print SimpleStubs") \
\
/* C1 optimizations */ \
Expand Down Expand Up @@ -188,10 +187,10 @@
"Percentage of prev. allowed inline size in recursive inlining") \
range(0, 100) \
\
notproduct(bool, PrintIRWithLIR, false, \
develop(bool, PrintIRWithLIR, false, \
"Print IR instructions with generated LIR") \
\
notproduct(bool, PrintLIRWithAssembly, false, \
develop(bool, PrintLIRWithAssembly, false, \
"Show LIR instruction with generated assembly") \
\
develop(bool, CommentedAssembly, trueInDebug, \
Expand Down
3 changes: 1 addition & 2 deletions src/hotspot/share/cds/cds_globals.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2022, 2023, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2022, 2024, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
Expand Down Expand Up @@ -35,7 +35,6 @@
develop_pd, \
product, \
product_pd, \
notproduct, \
range, \
constraint) \
/* Shared spaces */ \
Expand Down
7 changes: 3 additions & 4 deletions src/hotspot/share/compiler/compiler_globals.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 1997, 2023, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 1997, 2024, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
Expand Down Expand Up @@ -44,7 +44,6 @@
develop_pd, \
product, \
product_pd, \
notproduct, \
range, \
constraint) \
\
Expand Down Expand Up @@ -95,11 +94,11 @@
product(bool, CICompilerCountPerCPU, false, \
"1 compiler thread for log(N CPUs)") \
\
notproduct(intx, CICrashAt, -1, \
develop(intx, CICrashAt, -1, \
"id of compilation to trigger assert in compiler thread for " \
"the purpose of testing, e.g. generation of replay data") \
\
notproduct(bool, CIObjectFactoryVerify, false, \
develop(bool, CIObjectFactoryVerify, false, \
"enable potentially expensive verification in ciObjectFactory") \
\
develop(intx, CIStart, 0, \
Expand Down
3 changes: 1 addition & 2 deletions src/hotspot/share/gc/epsilon/epsilon_globals.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2020, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2020, 2024, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2017, 2018, Red Hat, Inc. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
Expand Down Expand Up @@ -36,7 +36,6 @@
develop_pd, \
product, \
product_pd, \
notproduct, \
range, \
constraint) \
\
Expand Down
Loading