Skip to content

Conversation

@aivanov-jdk
Copy link
Member

@aivanov-jdk aivanov-jdk commented Mar 29, 2024

Remove all the leftovers of the "standard instructions" machinery from the NullPaper.java test.

The test code consists of two lines now: concise and clear.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8329320: Simplify awt/print/PageFormat/NullPaper.java test (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18547/head:pull/18547
$ git checkout pull/18547

Update a local copy of the PR:
$ git checkout pull/18547
$ git pull https://git.openjdk.org/jdk.git pull/18547/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18547

View PR using the GUI difftool:
$ git pr show -t 18547

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18547.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 29, 2024

👋 Welcome back aivanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 29, 2024

@aivanov-jdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8329320: Simplify awt/print/PageFormat/NullPaper.java test

Reviewed-by: honkar, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

  • d3fc8df: 8329135: Store Universe::*exception_instance() in CDS archive
  • a85c849: 8328273: sun/management/jmxremote/bootstrap/RmiRegistrySslTest.java failed with java.rmi.server.ExportException: Port already in use
  • 70c8ff1: 8328665: serviceability/jvmti/vthread/PopFrameTest failed with a timeout
  • ecd2b71: 8329354: java/text/Format/MessageFormat/CompactSubFormats.java fails
  • c2979c1: 8329425: ProblemList containers/docker/TestJFREvents.java on linux-x64
  • 5698f7a: 8329134: Reconsider TLAB zapping
  • 4a14cba: 8329213: Better validation for com.sun.security.ocsp.useget option
  • 9f5464e: 8329353: ResolvedReferencesNotNullTest.java failed with Incorrect resolved references array, quxString should not be archived
  • 3f5b75a: 8328541: Remove or update obsolete comment in JRootPane
  • 1e76e1f: 8328403: Remove applet usage from JColorChooser tests Test6977726
  • ... and 8 more: https://git.openjdk.org/jdk/compare/418deaf5a1045d583ef9f5474d28dab31e2cfaf7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 29, 2024
@openjdk
Copy link

openjdk bot commented Mar 29, 2024

@aivanov-jdk The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Mar 29, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 29, 2024

Webrevs

Copy link
Contributor

@honkar-jdk honkar-jdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 30, 2024
@aivanov-jdk
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 2, 2024

Going to push as commit 5cf457b.
Since your change was applied there have been 26 commits pushed to the master branch:

  • 8b934aa: 8329358: Generational ZGC: Remove the unused method ZPointer::set_remset_bits
  • 3b582df: 8051959: Add thread and timestamp options to java.security.debug system property
  • 816638e: 8329352: Remove dead code in splashscreen_sys.c
  • 3d22838: 8328997: Remove unnecessary template parameter lists in GrowableArray
  • 5cddc2d: 8325252: C2 SuperWord: refactor the packset
  • 6b1b0e9: 8329103: assert(!thread->in_asgct()) failed during multi-mode profiling
  • bc546c2: 8328561: test java/awt/Robot/ManualInstructions/ManualInstructions.java isn't used
  • af7c6af: 8324808: Manual printer tests have no Pass/Fail buttons, instructions close set 3
  • d3fc8df: 8329135: Store Universe::*exception_instance() in CDS archive
  • a85c849: 8328273: sun/management/jmxremote/bootstrap/RmiRegistrySslTest.java failed with java.rmi.server.ExportException: Port already in use
  • ... and 16 more: https://git.openjdk.org/jdk/compare/418deaf5a1045d583ef9f5474d28dab31e2cfaf7...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 2, 2024
@openjdk openjdk bot closed this Apr 2, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 2, 2024
@openjdk
Copy link

openjdk bot commented Apr 2, 2024

@aivanov-jdk Pushed as commit 5cf457b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@aivanov-jdk aivanov-jdk deleted the 8329320-NullPaper branch April 2, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client client-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants