8329135: Store Universe::*exception_instance() in CDS archive

[iklam]

This is a preparation step for the AOT compiler in the Leyden project. The exception options are frequently accessed by compiled code. Having them inside the CDS archive will allow the AOT to generate smaller/better code.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8329135: Store Universe::*exception_instance() in CDS archive (Enhancement - P4)

Reviewers

• Vladimir Ivanov (@iwanowww - Reviewer) ⚠️ Review applies to 38f4d732
• Calvin Cheung (@calvinccheung - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18551/head:pull/18551
$ git checkout pull/18551

Update a local copy of the PR:
$ git checkout pull/18551
$ git pull https://git.openjdk.org/jdk.git pull/18551/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18551

View PR using the GUI difftool:
$ git pr show -t 18551

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18551.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back iklam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@iklam This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8329135: Store Universe::*exception_instance() in CDS archive

Reviewed-by: vlivanov, ccheung

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@iklam The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (08a9e6eb)
• 01: Full - Incremental (76c5a3cd)
• 00: Full (38f4d732)

[iwanowww]

Looks good.

[iwanowww]

s/guatanteed/guaranteed/

[calvinccheung]

Is it clearer to do the following?

  BuiltinException() {
    _instance();

[iklam]

Thanks @iwanowww and @calvinccheung for the review
/integrate

[openjdk]

Going to push as commit d3fc8df.
Since your change was applied there have been 2 commits pushed to the master branch:

• a85c849: 8328273: sun/management/jmxremote/bootstrap/RmiRegistrySslTest.java failed with java.rmi.server.ExportException: Port already in use
• 70c8ff1: 8328665: serviceability/jvmti/vthread/PopFrameTest failed with a timeout

Your commit was automatically rebased without conflicts.

[openjdk]

@iklam Pushed as commit d3fc8df.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.