Skip to content

8329332: Remove CompiledMethod and CodeBlobLayout classes #18554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

8329332: Remove CompiledMethod and CodeBlobLayout classes #18554

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
902ac55
8329332: Remove CompiledMethod and CodeBlobLayout classes
vnkozlov Mar 29, 2024
7635b33
remove trailing whitespace
vnkozlov Mar 30, 2024
246ff68
Removed not_used state of nmethod
vnkozlov Apr 1, 2024
f5068ff
Merge branch 'master' into 8329332
vnkozlov Apr 3, 2024
33768fb
Address comments
vnkozlov Apr 4, 2024
0c18ff1
Address next round of comments
vnkozlov Apr 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/hotspot/share/code/nmethod.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,8 +441,6 @@ const char* nmethod::state() const {
return "not installed";
case in_use:
return "in use";
case not_used:
return "not_used";
case not_entrant:
return "not_entrant";
default:
Expand Down
5 changes: 2 additions & 3 deletions src/hotspot/share/code/nmethod.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,7 @@ class nmethod : public CodeBlob {
bool _load_reported;

// Protected by CompiledMethod_lock
volatile signed char _state; // {not_installed, in_use, not_used, not_entrant}
volatile signed char _state; // {not_installed, in_use, not_entrant}

// set during construction
uint8_t _has_unsafe_access:1, // May fault due to unsafe access.
Expand Down Expand Up @@ -601,8 +601,7 @@ class nmethod : public CodeBlob {
enum : signed char { not_installed = -1, // in construction, only the owner doing the construction is
// allowed to advance state
in_use = 0, // executable nmethod
not_used = 1, // not entrant, but revivable
not_entrant = 2, // marked for deoptimization but activations may still exist
not_entrant = 1 // marked for deoptimization but activations may still exist
};

// flag accessing and manipulation
Expand Down