8329354: java/text/Format/MessageFormat/CompactSubFormats.java fails

[DamonFool]

Hi all,

java/text/Format/MessageFormat/CompactSubFormats.java fails in our testing machines.
I'm not an expert in this area and just guess it can be fixed like this.
Please review it.

Thanks.
Best regards,
Jie

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8329354: java/text/Format/MessageFormat/CompactSubFormats.java fails (Bug - P4)

Reviewers

• Justin Lu (@justin-curtis-lu - Committer)
• Naoto Sato (@naotoj - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18557/head:pull/18557
$ git checkout pull/18557

Update a local copy of the PR:
$ git checkout pull/18557
$ git pull https://git.openjdk.org/jdk.git pull/18557/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18557

View PR using the GUI difftool:
$ git pr show -t 18557

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18557.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jiefu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@DamonFool This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8329354: java/text/Format/MessageFormat/CompactSubFormats.java fails

Reviewed-by: jlu, naoto

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

• 3f5b75a: 8328541: Remove or update obsolete comment in JRootPane
• 1e76e1f: 8328403: Remove applet usage from JColorChooser tests Test6977726
• 9d052e9: 8329131: Fold libjli_static back into libjli on AIX
• f2e5808: 8329126: No native wrappers generated anymore with -XX:-TieredCompilation after JDK-8251462

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@DamonFool The following labels will be automatically applied to this pull request:

• core-libs
• i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (244cff09)

[justin-curtis-lu]

Hi Jie,

This is indeed the correct solution to ensure that the DecimalFormat, (specifically, the underlying DecimalFormatSymbols) has the same locale as the MessageFormat subformat.

Thank you for the fix, it LGTM

[DamonFool]

This is indeed the correct solution to ensure that the DecimalFormat, (specifically, the underlying DecimalFormatSymbols) has the same locale as the MessageFormat subformat.

Thanks @justin-curtis-lu for the review.

[DamonFool]

May I get one more review from a reviewer? Maybe @naotoj ?
Thanks.

[naotoj]

LGTM. Thanks for the fix.

[DamonFool]

Thanks @naotoj .
/integrate

[openjdk]

Going to push as commit ecd2b71.
Since your change was applied there have been 8 commits pushed to the master branch:

• c2979c1: 8329425: ProblemList containers/docker/TestJFREvents.java on linux-x64
• 5698f7a: 8329134: Reconsider TLAB zapping
• 4a14cba: 8329213: Better validation for com.sun.security.ocsp.useget option
• 9f5464e: 8329353: ResolvedReferencesNotNullTest.java failed with Incorrect resolved references array, quxString should not be archived
• 3f5b75a: 8328541: Remove or update obsolete comment in JRootPane
• 1e76e1f: 8328403: Remove applet usage from JColorChooser tests Test6977726
• 9d052e9: 8329131: Fold libjli_static back into libjli on AIX
• f2e5808: 8329126: No native wrappers generated anymore with -XX:-TieredCompilation after JDK-8251462

Your commit was automatically rebased without conflicts.

[openjdk]

@DamonFool Pushed as commit ecd2b71.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.