8329358: Generational ZGC: Remove the unused method ZPointer::set_remset_bits

[lgxbslgx]

Hi all,

This patch removes the unused method ZPointer::set_remset_bits. It seems that we don't need to set two remembered bits at the same time.

Thanks for taking the time to review.

Best Regards,
-- Guoxiong

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8329358: Generational ZGC: Remove the unused method ZPointer::set_remset_bits (Enhancement - P5)

Reviewers

• Stefan Karlsson (@stefank - Reviewer)
• Erik Österlund (@fisk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18559/head:pull/18559
$ git checkout pull/18559

Update a local copy of the PR:
$ git checkout pull/18559
$ git pull https://git.openjdk.org/jdk.git pull/18559/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18559

View PR using the GUI difftool:
$ git pr show -t 18559

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18559.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back gli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@lgxbslgx This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8329358: Generational ZGC: Remove the unused method ZPointer::set_remset_bits

Reviewed-by: stefank, eosterlund

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

• 3b582df: 8051959: Add thread and timestamp options to java.security.debug system property
• 816638e: 8329352: Remove dead code in splashscreen_sys.c
• 3d22838: 8328997: Remove unnecessary template parameter lists in GrowableArray
• 5cddc2d: 8325252: C2 SuperWord: refactor the packset
• 6b1b0e9: 8329103: assert(!thread->in_asgct()) failed during multi-mode profiling
• bc546c2: 8328561: test java/awt/Robot/ManualInstructions/ManualInstructions.java isn't used
• af7c6af: 8324808: Manual printer tests have no Pass/Fail buttons, instructions close set 3
• d3fc8df: 8329135: Store Universe::*exception_instance() in CDS archive
• a85c849: 8328273: sun/management/jmxremote/bootstrap/RmiRegistrySslTest.java failed with java.rmi.server.ExportException: Port already in use
• 70c8ff1: 8328665: serviceability/jvmti/vthread/PopFrameTest failed with a timeout
• ... and 8 more: https://git.openjdk.org/jdk/compare/f2e5808b46a3da6920dd56688c877ee0e2795de6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@lgxbslgx The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (9b6840d1)

[lgxbslgx]

@stefank @fisk Thanks for the review.

/integrate

[openjdk]

Going to push as commit 8b934aa.
Since your change was applied there have been 18 commits pushed to the master branch:

• 3b582df: 8051959: Add thread and timestamp options to java.security.debug system property
• 816638e: 8329352: Remove dead code in splashscreen_sys.c
• 3d22838: 8328997: Remove unnecessary template parameter lists in GrowableArray
• 5cddc2d: 8325252: C2 SuperWord: refactor the packset
• 6b1b0e9: 8329103: assert(!thread->in_asgct()) failed during multi-mode profiling
• bc546c2: 8328561: test java/awt/Robot/ManualInstructions/ManualInstructions.java isn't used
• af7c6af: 8324808: Manual printer tests have no Pass/Fail buttons, instructions close set 3
• d3fc8df: 8329135: Store Universe::*exception_instance() in CDS archive
• a85c849: 8328273: sun/management/jmxremote/bootstrap/RmiRegistrySslTest.java failed with java.rmi.server.ExportException: Port already in use
• 70c8ff1: 8328665: serviceability/jvmti/vthread/PopFrameTest failed with a timeout
• ... and 8 more: https://git.openjdk.org/jdk/compare/f2e5808b46a3da6920dd56688c877ee0e2795de6...master

Your commit was automatically rebased without conflicts.

[openjdk]

@lgxbslgx Pushed as commit 8b934aa.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.