Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8320799: Bump minimum boot jdk to JDK 22 #18563

Closed
wants to merge 1 commit into from

Conversation

vidmik
Copy link
Contributor

@vidmik vidmik commented Apr 1, 2024

With the JDK 22 GA out it's time to bump the minimum boot JDK version for mainline/JDK 23.

Testing: tier1-5, GHA


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8320799: Bump minimum boot jdk to JDK 22 (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18563/head:pull/18563
$ git checkout pull/18563

Update a local copy of the PR:
$ git checkout pull/18563
$ git pull https://git.openjdk.org/jdk.git pull/18563/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18563

View PR using the GUI difftool:
$ git pr show -t 18563

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18563.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 1, 2024

👋 Welcome back mikael! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 1, 2024

@vidmik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8320799: Bump minimum boot jdk to JDK 22

Reviewed-by: iris, erikj, ihse

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 47 new commits pushed to the master branch:

  • bdd9438: 8328647: TestGarbageCollectorMXBean.java fails with C1-only and -Xcomp
  • e3e6c2a: 8328278: Do not print the tenuring threshold in AgeTable::print_on
  • 16b842a: 8329355: Test compiler/c2/irTests/TestIfMinMax.java fails on RISC-V
  • 92f5c0b: 8323682: C2: guard check is not generated in Arrays.copyOfRange intrinsic when allocation is eliminated by EA
  • 866e7b6: 8329174: update CodeBuffer layout in comment after constants section moved
  • f88f31d: 8328137: PreserveAllAnnotations can cause failure of class retransformation
  • 021ed6a: 8328648: Remove applet usage from JFileChooser tests bug4150029
  • 3057dde: 8329421: Native methods can not be selectively printed
  • db15914: 8328753: Open source few Undecorated Frame tests
  • 925d829: 8329013: StackOverflowError when starting Apache Tomcat with signed jar
  • ... and 37 more: https://git.openjdk.org/jdk/compare/991e04e7d7ff3ee682c2b8a9b860d325a176e7a5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Apr 1, 2024

@vidmik The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build build-dev@openjdk.org label Apr 1, 2024
@vidmik vidmik changed the title Draft: 8320799: Bump minimum boot jdk to JDK 22 8320799: Bump minimum boot jdk to JDK 22 Apr 1, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 1, 2024
@mlbridge
Copy link

mlbridge bot commented Apr 1, 2024

Webrevs

Copy link
Member

@irisclark irisclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 1, 2024
@vidmik
Copy link
Contributor Author

vidmik commented Apr 3, 2024

Thank you for the reviews!

/integrate

@openjdk
Copy link

openjdk bot commented Apr 3, 2024

Going to push as commit 023f7f1.
Since your change was applied there have been 53 commits pushed to the master branch:

  • 8dc43aa: 8325217: MethodSymbol.getModifiers() returns SEALED for restricted methods
  • 1c69193: 8328383: Method is not used: com.sun.tools.javac.comp.Attr::thisSym
  • ee09801: 8328352: Serial: Inline SerialBlockOffsetSharedArray
  • bea493b: 8236736: Change notproduct JVM flags to develop flags
  • 80c54b4: 8328932: Parallel: Proper partial object setup in fill_dense_prefix_end
  • d954f3b: 8329493: Parallel: Remove unused ParallelArguments::heap_max_size_bytes
  • bdd9438: 8328647: TestGarbageCollectorMXBean.java fails with C1-only and -Xcomp
  • e3e6c2a: 8328278: Do not print the tenuring threshold in AgeTable::print_on
  • 16b842a: 8329355: Test compiler/c2/irTests/TestIfMinMax.java fails on RISC-V
  • 92f5c0b: 8323682: C2: guard check is not generated in Arrays.copyOfRange intrinsic when allocation is eliminated by EA
  • ... and 43 more: https://git.openjdk.org/jdk/compare/991e04e7d7ff3ee682c2b8a9b860d325a176e7a5...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 3, 2024
@openjdk openjdk bot closed this Apr 3, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 3, 2024
@openjdk
Copy link

openjdk bot commented Apr 3, 2024

@vidmik Pushed as commit 023f7f1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

4 participants