Skip to content

Conversation

@dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Apr 1, 2024

Trivial fixes to ProblemList noisy tests:

JDK-8329425 ProblemList containers/docker/TestJFREvents.java on linux-x64
JDK-8329426 ProblemList vmTestbase/nsk/jvmti/scenarios/capability/CM03/cm03t001/TestDescription.java with Xcomp on windows-x64
JDK-8329427 ProblemList javax/sound/sampled/Clip/ClipFlushCrash.java on linux-x64
JDK-8329428 ProblemList vmTestbase/nsk/stress/thread/thread006.java on linux-all in Xcomp


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-8329425: ProblemList containers/docker/TestJFREvents.java on linux-x64 (Sub-task - P4)
  • JDK-8329426: ProblemList vmTestbase/nsk/jvmti/scenarios/capability/CM03/cm03t001/TestDescription.java with Xcomp on windows-x64 (Sub-task - P4)
  • JDK-8329427: ProblemList javax/sound/sampled/Clip/ClipFlushCrash.java on linux-x64 (Sub-task - P4)
  • JDK-8329428: ProblemList vmTestbase/nsk/stress/thread/thread006.java on linux-all in Xcomp (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18568/head:pull/18568
$ git checkout pull/18568

Update a local copy of the PR:
$ git checkout pull/18568
$ git pull https://git.openjdk.org/jdk.git pull/18568/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18568

View PR using the GUI difftool:
$ git pr show -t 18568

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18568.diff

Webrev

Link to Webrev Comment

@dcubed-ojdk
Copy link
Member Author

/label add hotspot-runtime

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 1, 2024

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 1, 2024

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8329425: ProblemList containers/docker/TestJFREvents.java on linux-x64
8329426: ProblemList vmTestbase/nsk/jvmti/scenarios/capability/CM03/cm03t001/TestDescription.java with Xcomp on windows-x64
8329427: ProblemList javax/sound/sampled/Clip/ClipFlushCrash.java on linux-x64
8329428: ProblemList vmTestbase/nsk/stress/thread/thread006.java on linux-all in Xcomp

Reviewed-by: dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Apr 1, 2024
@openjdk
Copy link

openjdk bot commented Apr 1, 2024

@dcubed-ojdk
The hotspot-runtime label was successfully added.

…m03t001/TestDescription.java with Xcomp on windows-x64
@dcubed-ojdk
Copy link
Member Author

/label add serviceability

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Apr 1, 2024
@openjdk
Copy link

openjdk bot commented Apr 1, 2024

@dcubed-ojdk
The serviceability label was successfully added.

@dcubed-ojdk
Copy link
Member Author

/label add client
/label add hotspot-compiler

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Apr 1, 2024
@openjdk
Copy link

openjdk bot commented Apr 1, 2024

@dcubed-ojdk
The client label was successfully added.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Apr 1, 2024
@openjdk
Copy link

openjdk bot commented Apr 1, 2024

@dcubed-ojdk
The hotspot-compiler label was successfully added.

@dcubed-ojdk
Copy link
Member Author

/issue JDK-8329425
/issue JDK-8329426
/issue JDK-8329427
/issue JDK-8329428

@openjdk
Copy link

openjdk bot commented Apr 1, 2024

@dcubed-ojdk This issue is referenced in the PR title - it will now be updated.

@openjdk
Copy link

openjdk bot commented Apr 1, 2024

@dcubed-ojdk
Adding additional issue to issue list: 8329426: ProblemList vmTestbase/nsk/jvmti/scenarios/capability/CM03/cm03t001/TestDescription.java with Xcomp on windows-x64.

@openjdk
Copy link

openjdk bot commented Apr 1, 2024

@dcubed-ojdk
Adding additional issue to issue list: 8329427: ProblemList javax/sound/sampled/Clip/ClipFlushCrash.java on linux-x64.

@openjdk
Copy link

openjdk bot commented Apr 1, 2024

@dcubed-ojdk
Adding additional issue to issue list: 8329428: ProblemList vmTestbase/nsk/stress/thread/thread006.java on linux-all in Xcomp.

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review April 1, 2024 22:12
@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 1, 2024
Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems okay. Thanks

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 1, 2024
@mlbridge
Copy link

mlbridge bot commented Apr 1, 2024

Webrevs

@dcubed-ojdk
Copy link
Member Author

@dholmes-ora - Thanks for the lightning fast review!

/integrate

@openjdk
Copy link

openjdk bot commented Apr 1, 2024

Going to push as commit c2979c1.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 1, 2024
@openjdk openjdk bot closed this Apr 1, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 1, 2024
@openjdk
Copy link

openjdk bot commented Apr 1, 2024

@dcubed-ojdk Pushed as commit c2979c1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dcubed-ojdk dcubed-ojdk deleted the JDK-8329425 branch April 1, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client client-libs-dev@openjdk.org hotspot-compiler hotspot-compiler-dev@openjdk.org hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

2 participants