Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8329470: Remove obsolete CDS SharedStrings tests #18573

Conversation

iklam
Copy link
Member

@iklam iklam commented Apr 2, 2024

These tests are quite time consuming. Removing them will speed up the CDS tests cycle.

[1] The LockSharedStrings.java test is obsolete. The archived strings used to be in its own "special" G1 region and we needed a test to check if locking objects in this region is working properly. Today all archived heap objects are stored in regular G1 regions. This test is no longer needed.

[2] During CDS dump time, we no longer allocate extra copies of the archived heap objects in the actual Java heap. So we can removed the portion of SharedStringsStress.java that tests for "an extra copy of these objects are allocated".


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8329470: Remove obsolete CDS SharedStrings tests (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18573/head:pull/18573
$ git checkout pull/18573

Update a local copy of the PR:
$ git checkout pull/18573
$ git pull https://git.openjdk.org/jdk.git pull/18573/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18573

View PR using the GUI difftool:
$ git pr show -t 18573

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18573.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 2, 2024

👋 Welcome back iklam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 2, 2024

@iklam This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8329470: Remove obsolete CDS SharedStrings tests

Reviewed-by: ccheung

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

  • 925d829: 8329013: StackOverflowError when starting Apache Tomcat with signed jar
  • dd5d7d0: 8327002: (fs) java/nio/file/Files/CopyMoveVariations.java should be able to test across file systems
  • 6ae1cf1: 8329368: Generational ZGC: Remove the unnecessary friend classes in ZAllocator
  • 7eb78e3: 8320676: Manual printer tests have no Pass/Fail buttons, instructions close set 1
  • 5ac067f: 8329289: Unify SetupJdkExecutable and SetupJdkLibrary
  • 5ae849d: 8329292: Fix missing cleanups in java.management and jdk.management
  • ed821cb: 8324807: Manual printer tests have no Pass/Fail buttons, instructions close set 2
  • 5cf457b: 8329320: Simplify awt/print/PageFormat/NullPaper.java test
  • 8b934aa: 8329358: Generational ZGC: Remove the unused method ZPointer::set_remset_bits
  • 3b582df: 8051959: Add thread and timestamp options to java.security.debug system property
  • ... and 9 more: https://git.openjdk.org/jdk/compare/ecd2b7112a7617b11997da341d6185756bf1fb0f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 2, 2024
@openjdk
Copy link

openjdk bot commented Apr 2, 2024

@iklam The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Apr 2, 2024
@mlbridge
Copy link

mlbridge bot commented Apr 2, 2024

Webrevs

Copy link
Member

@calvinccheung calvinccheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 2, 2024
@iklam
Copy link
Member Author

iklam commented Apr 3, 2024

Thanks Calvin for the review.
/integrate

@openjdk
Copy link

openjdk bot commented Apr 3, 2024

Going to push as commit 8020183.
Since your change was applied there have been 39 commits pushed to the master branch:

  • 8267d65: 8329564: [JVMCI] TranslatedException::debugPrintStackTrace does not work in the libjvmci compiler.
  • 16576b8: 8328957: Update PKCS11Test.java to not use hardcoded path
  • 375bfac: 8327474: Review use of java.io.tmpdir in jdk tests
  • 233619b: 8329557: Fix statement around MathContext.DECIMAL128 rounding
  • 023f7f1: 8320799: Bump minimum boot jdk to JDK 22
  • 8dc43aa: 8325217: MethodSymbol.getModifiers() returns SEALED for restricted methods
  • 1c69193: 8328383: Method is not used: com.sun.tools.javac.comp.Attr::thisSym
  • ee09801: 8328352: Serial: Inline SerialBlockOffsetSharedArray
  • bea493b: 8236736: Change notproduct JVM flags to develop flags
  • 80c54b4: 8328932: Parallel: Proper partial object setup in fill_dense_prefix_end
  • ... and 29 more: https://git.openjdk.org/jdk/compare/ecd2b7112a7617b11997da341d6185756bf1fb0f...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 3, 2024
@openjdk openjdk bot closed this Apr 3, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 3, 2024
@openjdk
Copy link

openjdk bot commented Apr 3, 2024

@iklam Pushed as commit 8020183.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
2 participants