Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8329510: Update ProblemList for JFileChooser/8194044/FileSystemRootTest.java #18580

Closed

Conversation

aivanov-jdk
Copy link
Member

@aivanov-jdk aivanov-jdk commented Apr 2, 2024

Update the problem-list entry for javax/swing/JFileChooser/8194044/FileSystemRootTest.java to refer to JDK-8327236 under which the failure with "root drive reported as false" is tracked.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8329510: Update ProblemList for JFileChooser/8194044/FileSystemRootTest.java (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18580/head:pull/18580
$ git checkout pull/18580

Update a local copy of the PR:
$ git checkout pull/18580
$ git pull https://git.openjdk.org/jdk.git pull/18580/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18580

View PR using the GUI difftool:
$ git pr show -t 18580

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18580.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 2, 2024

👋 Welcome back aivanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 2, 2024

@aivanov-jdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8329510: Update ProblemList for JFileChooser/8194044/FileSystemRootTest.java

Reviewed-by: abhiscxk, dmarkov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 79 new commits pushed to the master branch:

  • 3ebf8c9: 8329663: hs_err file event log entry for thread adding/removing should print current thread
  • be45de1: 8328627: JShell documentation should be clearer about "remote runtime system"
  • 8648890: 8329749: Obsolete the unused UseNeon flag
  • fc18201: 8327111: Replace remaining usage of create_bool_from_template_assertion_predicate() which requires additional OpaqueLoop*Nodes transformation strategies
  • 7c66465: 8325088: Overloads that differ in type parameters may be lost
  • 6f087cb: 8328698: oopDesc::klass_raw() decodes without a null check
  • d1aad71: 8321204: C2: assert(false) failed: node should be in igvn hash table
  • 51b0abc: 8329340: Remove unused libawt code
  • 3a3b77d: 8329641: RISC-V: Enable some tests related to SHA-2 instrinsic
  • d771ec6: 8329733: Update the documentation in java.net.SocketOptions to direct to java.net.StandardSocketOptions
  • ... and 69 more: https://git.openjdk.org/jdk/compare/8b934aab1402ea74ac1fb7b56bfb9840f932ccb1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 2, 2024
@openjdk
Copy link

openjdk bot commented Apr 2, 2024

@aivanov-jdk To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@aivanov-jdk
Copy link
Member Author

/label client

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Apr 2, 2024
@openjdk
Copy link

openjdk bot commented Apr 2, 2024

@aivanov-jdk
The client label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Apr 2, 2024

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 8, 2024
@aivanov-jdk
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 8, 2024

Going to push as commit 7475824.
Since your change was applied there have been 80 commits pushed to the master branch:

  • 6439375: 8329533: TestCDSVMCrash fails on libgraal
  • 3ebf8c9: 8329663: hs_err file event log entry for thread adding/removing should print current thread
  • be45de1: 8328627: JShell documentation should be clearer about "remote runtime system"
  • 8648890: 8329749: Obsolete the unused UseNeon flag
  • fc18201: 8327111: Replace remaining usage of create_bool_from_template_assertion_predicate() which requires additional OpaqueLoop*Nodes transformation strategies
  • 7c66465: 8325088: Overloads that differ in type parameters may be lost
  • 6f087cb: 8328698: oopDesc::klass_raw() decodes without a null check
  • d1aad71: 8321204: C2: assert(false) failed: node should be in igvn hash table
  • 51b0abc: 8329340: Remove unused libawt code
  • 3a3b77d: 8329641: RISC-V: Enable some tests related to SHA-2 instrinsic
  • ... and 70 more: https://git.openjdk.org/jdk/compare/8b934aab1402ea74ac1fb7b56bfb9840f932ccb1...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 8, 2024
@openjdk openjdk bot closed this Apr 8, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 8, 2024
@openjdk
Copy link

openjdk bot commented Apr 8, 2024

@aivanov-jdk Pushed as commit 7475824.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@aivanov-jdk aivanov-jdk deleted the 8329510-PL-FileSystemRootTest branch April 8, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants