JDK-8329089: Empty immutable list throws the wrong exception type for remove(first | last) operations

[minborg]

This PR proposes to make empty immutable lists always throw UOE on removeFirst and removeLast.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8329089: Empty immutable list throws the wrong exception type for remove(first | last) operations (Bug - P4)

Reviewers

• Roger Riggs (@RogerRiggs - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18581/head:pull/18581
$ git checkout pull/18581

Update a local copy of the PR:
$ git checkout pull/18581
$ git pull https://git.openjdk.org/jdk.git pull/18581/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18581

View PR using the GUI difftool:
$ git pr show -t 18581

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18581.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back pminborg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@minborg This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8329089: Empty immutable list throws the wrong exception type for remove(first | last) operations

Reviewed-by: rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 40 new commits pushed to the master branch:

• 21867c9: 8313332: Simplify lazy jmethodID cache in InstanceKlass
• b9da140: 8329594: G1: Consistent Titles to Thread Work Items.
• a169c06: 8329580: Parallel: Remove VerifyObjectStartArray
• 8efd7aa: 8328786: [AIX] move some important warnings/errors from trcVerbose to UL
• f26e430: 8327110: Refactor create_bool_from_template_assertion_predicate() to separate class and fix identical cloning cases used for Loop Unswitching and Split If
• e5e21a8: 8328702: C2: Crash during parsing because sub type check is not folded
• f762637: 8326962: C2 SuperWord: cache VPointer
• 2931458: 8328938: C2 SuperWord: disable vectorization for large stride and scale
• 4196688: 8329494: Serial: Merge GenMarkSweep into MarkSweep
• 8020183: 8329470: Remove obsolete CDS SharedStrings tests
• ... and 30 more: https://git.openjdk.org/jdk/compare/816638e3bedef9f57c438dfd2f9837acbb93ff90...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@minborg The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (af1c9a13)

[RogerRiggs]

Would this test better if inserted in testImmutableCollection(final Collection<T> c, T t), Line 477'ish.
Or in testImmutableList(final List<Integer> c), line 519.

[minborg]

Unfortunately, the remove(F|L) methods are not available for general collections. testImmutableList() is also applied for unmodifiable lists (like Collections.emptyList() and Collections.nCopies(0, ...)) that seem to behave differently (they throw NSEE). The latter have different specifications compared to an immutable list.

[RogerRiggs]

LGTM

[minborg]

/integrate

[openjdk]

Going to push as commit b71acc7.
Since your change was applied there have been 57 commits pushed to the master branch:

• 1131bb7: 8329261: G1: interpreter post-barrier x86 code asserts index size of wrong buffer
• 6bc6392: 8329201: C2: Replace TypeInterfaces::intersection_with() + eq() with contains()
• 9da5170: 8327978: C2 SuperWord: Fix compilation time regression in dependency graph traversal after JDK-8325651
• c1cfb43: 8329109: Threads::print_on() tries to print CPU time for terminated GC threads
• 5860a48: 8329624: Add visitors for preview language features
• 0b01144: 8329720: Gtest failure printing markword after JDK-8325303
• 34f7974: 8325303: Replace markWord.is_neutral() with markWord.is_unlocked()
• 27cfcef: 8329651: TestLibGraal.java crashes with assert(_stack_base != nullptr)
• e1183ac: 8329703: Remove unused apple.jpeg file from SwingSet2 demo
• 12ad09a: 8322042: HeapDumper should perform merge on the current thread instead of VMThread
• ... and 47 more: https://git.openjdk.org/jdk/compare/816638e3bedef9f57c438dfd2f9837acbb93ff90...master

Your commit was automatically rebased without conflicts.

[openjdk]

@minborg Pushed as commit b71acc7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.