Skip to content

8329538: Accelerate P256 on x86_64 using Montgomery intrinsic #18583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 17 commits into from
Closed

8329538: Accelerate P256 on x86_64 using Montgomery intrinsic #18583

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
e36a552
rebase
vpaprotsk Sep 26, 2023
6285a33
conditionalAssign intrinsic
vpaprotsk Oct 10, 2023
c431528
Address comments from Anas and thorough cleanup
vpaprotsk Feb 19, 2024
bc8d611
Fix rebase typo
vpaprotsk Mar 26, 2024
7bf06b7
Remeasure performance
vpaprotsk Mar 29, 2024
dbe6cd3
remove trailing whitespace
vpaprotsk Apr 2, 2024
82b6dae
remove use of jdk.crypto.ec
vpaprotsk Apr 2, 2024
6f9ac04
Comments from Jatin and Tony
vpaprotsk Apr 15, 2024
c93a71f
Comments from Tony and Jatin
vpaprotsk Apr 24, 2024
a198450
whitespace
vpaprotsk Apr 25, 2024
8ff243a
Use AffinePoint to exit Montgomery domain
vpaprotsk May 6, 2024
1ecfdc4
whitespace
vpaprotsk May 9, 2024
83b2131
add message back
vpaprotsk May 10, 2024
8cd095d
whitespace
vpaprotsk May 10, 2024
5c360e3
comments from Sandhya
vpaprotsk May 17, 2024
df4fe6f
shenandoah verifier
vpaprotsk May 17, 2024
b1a3300
Merge remote-tracking branch 'origin/master' into ecc-montgomery
vpaprotsk May 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/hotspot/cpu/x86/stubGenerator_x86_64_poly_mont.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,7 @@ address StubGenerator::generate_intpoly_assign() {
__ negq(set);
__ kmovql(select, set);

// NOTE! Crypto code cannot branch on user input. However; allowed to branch on number of limbs;
// NOTE! Crypto code cannot branch on user input. However; allowed to branch on number of limbs;
// Number of limbs is a constant in each IntegerPolynomial (i.e. this side-channel branch leaks
// number of limbs which is not a secret)
__ cmpl(length, 5);
Expand Down
4 changes: 2 additions & 2 deletions src/java.base/share/classes/sun/security/ec/ECOperations.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,11 +281,11 @@ private void setDouble(ProjectivePoint.Mutable p, MutableIntegerModuloP t0,

/**
* Adds second Mutable (Projective) point to first.
*
*
* Used by ECDSAOperations. This method constructs new temporaries each time
* it is called. For better efficiency, the (private) method that reuses temporaries
* should be used if more than one sum will be computed.
*
*
* @param p first point and result
* @param p2 second point to add
*/
Expand Down