JDK-8329564: [JVMCI] TranslatedException::debugPrintStackTrace does not work in the libjvmci compiler.

[tzezula]

Problem:
The debugging stack traces in jdk.internal.vm.TranslatedException do not work in libjvmci because they are enabled via the jdk.internal.vm.TranslatedException.debug system property. However, HotSpot system properties are not accessible via System.getProperty() in libjvmci.

Fix:
The value of jdk.internal.vm.TranslatedException.debug is passed from the VM via a boolean flag to VMSupport::decodeAndThrowThrowable().

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8329564: [JVMCI] TranslatedException::debugPrintStackTrace does not work in the libjvmci compiler. (Bug - P4)

Reviewers

• Doug Simon (@dougxc - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18591/head:pull/18591
$ git checkout pull/18591

Update a local copy of the PR:
$ git checkout pull/18591
$ git pull https://git.openjdk.org/jdk.git pull/18591/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18591

View PR using the GUI difftool:
$ git pr show -t 18591

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18591.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back tzezula! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tzezula This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8329564: [JVMCI] TranslatedException::debugPrintStackTrace does not work in the libjvmci compiler.

Reviewed-by: dnsimon

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 64 new commits pushed to the master branch:

• 16576b8: 8328957: Update PKCS11Test.java to not use hardcoded path
• 375bfac: 8327474: Review use of java.io.tmpdir in jdk tests
• 233619b: 8329557: Fix statement around MathContext.DECIMAL128 rounding
• 023f7f1: 8320799: Bump minimum boot jdk to JDK 22
• 8dc43aa: 8325217: MethodSymbol.getModifiers() returns SEALED for restricted methods
• 1c69193: 8328383: Method is not used: com.sun.tools.javac.comp.Attr::thisSym
• ee09801: 8328352: Serial: Inline SerialBlockOffsetSharedArray
• bea493b: 8236736: Change notproduct JVM flags to develop flags
• 80c54b4: 8328932: Parallel: Proper partial object setup in fill_dense_prefix_end
• d954f3b: 8329493: Parallel: Remove unused ParallelArguments::heap_max_size_bytes
• ... and 54 more: https://git.openjdk.org/jdk/compare/7c7b961e732d1bef3c95a69758e283c8fb32fff6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dougxc) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@tzezula The following labels will be automatically applied to this pull request:

• core-libs
• graal
• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (de30637b)
• 01: Full - Incremental (3a34ce27)
• 00: Full (5e43f5f7)

[openjdk]

⚠️ @tzezula the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout JDK-8329564
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push

[tzezula]

/integrate

[openjdk]

@tzezula
Your change (at version de30637) is now ready to be sponsored by a Committer.

[dougxc]

/sponsor

[openjdk]

Going to push as commit 8267d65.
Since your change was applied there have been 64 commits pushed to the master branch:

• 16576b8: 8328957: Update PKCS11Test.java to not use hardcoded path
• 375bfac: 8327474: Review use of java.io.tmpdir in jdk tests
• 233619b: 8329557: Fix statement around MathContext.DECIMAL128 rounding
• 023f7f1: 8320799: Bump minimum boot jdk to JDK 22
• 8dc43aa: 8325217: MethodSymbol.getModifiers() returns SEALED for restricted methods
• 1c69193: 8328383: Method is not used: com.sun.tools.javac.comp.Attr::thisSym
• ee09801: 8328352: Serial: Inline SerialBlockOffsetSharedArray
• bea493b: 8236736: Change notproduct JVM flags to develop flags
• 80c54b4: 8328932: Parallel: Proper partial object setup in fill_dense_prefix_end
• d954f3b: 8329493: Parallel: Remove unused ParallelArguments::heap_max_size_bytes
• ... and 54 more: https://git.openjdk.org/jdk/compare/7c7b961e732d1bef3c95a69758e283c8fb32fff6...master

Your commit was automatically rebased without conflicts.

[openjdk]

@dougxc @tzezula Pushed as commit 8267d65.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.