Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8258792: LogCompilation: remove redundant check fixed by 8257518 #1860

Closed
wants to merge 1 commit into from

Conversation

ericcaspole
Copy link

@ericcaspole ericcaspole commented Dec 21, 2020

There is no need to do the same check again doing -U processing, it is already done during XML parsing.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8258792: LogCompilation: remove redundant check fixed by 8257518

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1860/head:pull/1860
$ git checkout pull/1860

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 21, 2020

👋 Welcome back ecaspole! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 21, 2020

@ericcaspole The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Dec 21, 2020
@ericcaspole ericcaspole changed the title 8258792:LogCompilation: remove redundant check fixed by 8257518 8258792: LogCompilation: remove redundant check fixed by 8257518 Dec 21, 2020
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 21, 2020
@mlbridge
Copy link

mlbridge bot commented Dec 21, 2020

Webrevs

@openjdk
Copy link

openjdk bot commented Dec 21, 2020

@ericcaspole This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8258792: LogCompilation: remove redundant check fixed by 8257518

Reviewed-by: kvn, redestad

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 96 new commits pushed to the master branch:

  • 2e99e28: 8213126: java/awt/Window/MainKeyWindow/TestMainKeyWindow.java time-out on mac10.13
  • 8530ef0: 8259375: JvmtiExport::jni_Get/SetField_probe calls do not need ResetNoHandleMark
  • f91f92d: 8259317: Remove JVM option BreakAtWarning
  • 3f9f86f: 8258484: AIX build fails in Harfbuzz with XLC 16.01.0000.0006
  • 1c33847: 8259067: bootclasspath append takes out object lock
  • 0e6de4e: 8259339: AllocateUninitializedArray C2 intrinsic fails with void.class input
  • 81c0624: 8259354: Fix race condition in AbstractEventStream.nextThreadName
  • 227f99d: 8233555: [TESTBUG] JRadioButton tests failing on MacoS
  • 67c2211: 8259045: Exception message from saproc.dll is garbled on Windows with Japanese locale
  • 28e1f4d: 8247957: remove doclint support for HTML 4
  • ... and 86 more: https://git.openjdk.java.net/jdk/compare/a06cea50a5ea04fb0399d7ea3f6a2a20d9b4d254...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 21, 2020
cl4es
cl4es approved these changes Jan 7, 2021
@ericcaspole
Copy link
Author

/integrate

@openjdk openjdk bot closed this Jan 8, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 8, 2021
@openjdk
Copy link

openjdk bot commented Jan 8, 2021

@ericcaspole Since your change was applied there have been 130 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Pushed as commit 6f7723b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@ericcaspole ericcaspole deleted the JDK-8258792 branch January 8, 2021 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
3 participants