Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8329545: [s390x] Fix garbage value being passed in Argument Register #18601

Closed
wants to merge 2 commits into from

Conversation

sid8606
Copy link
Member

@sid8606 sid8606 commented Apr 3, 2024

Fix sign extension on 4 byte load from argument stack slot to GPR.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8329545: [s390x] Fix garbage value being passed in Argument Register (Bug - P2)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18601/head:pull/18601
$ git checkout pull/18601

Update a local copy of the PR:
$ git checkout pull/18601
$ git pull https://git.openjdk.org/jdk.git pull/18601/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18601

View PR using the GUI difftool:
$ git pr show -t 18601

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18601.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 3, 2024

👋 Welcome back sjayagond! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 3, 2024

@sid8606 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8329545: [s390x] Fix garbage value being passed in Argument Register

Reviewed-by: amitkumar, mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 111 new commits pushed to the master branch:

  • 51ed69a: 8327621: Check return value of uname in os::get_host_name
  • bea9acc: 8328482: Convert and Open source few manual applet test to main based
  • d037a59: 8311248: Refactor CodeCache::initialize_heaps to simplify adding new CodeCache segments
  • bab7019: 8329431: Improve speed of writing CDS heap objects
  • 47df145: 8310513: [s390x] Intrinsify recursive ObjectMonitor locking
  • b81b86d: 8329729: java/util/Properties/StoreReproducibilityTest.java times out
  • 6276789: 8328785: IOException: Symbol not found: C_GetInterface for PKCS11 interface prior to V3.0
  • 316361b: 8328318: Wrong description in X509Extension.getExtensionValue method javadoc
  • b80ba08: 8329967: Build failure after JDK-8329628
  • 4bba445: 8325659: Normalize Random usage by incubator vector tests
  • ... and 101 more: https://git.openjdk.org/jdk/compare/866e7b6b7745928e559da8cdf622bf6a097ec995...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@offamitkumar, @TheRealMDoerr) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title 8329545 8329545: [s390x] Fix garbage value being passed in Argument Register Apr 3, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 3, 2024
@openjdk
Copy link

openjdk bot commented Apr 3, 2024

@sid8606 The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Apr 3, 2024
@mlbridge
Copy link

mlbridge bot commented Apr 3, 2024

Webrevs

@offamitkumar
Copy link
Member

Please update copyright headers as well.

Copy link
Member

@offamitkumar offamitkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have done {tier1} X {fastdebug, slowdebug, release} test and do not see any new failure appearing.

Thanks Sid for fixing it.

@sid8606
Copy link
Member Author

sid8606 commented Apr 10, 2024

@TheRealMDoerr Could you please review this patch?

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 10, 2024
@sid8606
Copy link
Member Author

sid8606 commented Apr 10, 2024

Thanks for the reviews. I integrate now.
/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Apr 10, 2024
@openjdk
Copy link

openjdk bot commented Apr 10, 2024

@sid8606
Your change (at version e4e9729) is now ready to be sponsored by a Committer.

@offamitkumar
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Apr 10, 2024

Going to push as commit e0fd6c4.
Since your change was applied there have been 111 commits pushed to the master branch:

  • 51ed69a: 8327621: Check return value of uname in os::get_host_name
  • bea9acc: 8328482: Convert and Open source few manual applet test to main based
  • d037a59: 8311248: Refactor CodeCache::initialize_heaps to simplify adding new CodeCache segments
  • bab7019: 8329431: Improve speed of writing CDS heap objects
  • 47df145: 8310513: [s390x] Intrinsify recursive ObjectMonitor locking
  • b81b86d: 8329729: java/util/Properties/StoreReproducibilityTest.java times out
  • 6276789: 8328785: IOException: Symbol not found: C_GetInterface for PKCS11 interface prior to V3.0
  • 316361b: 8328318: Wrong description in X509Extension.getExtensionValue method javadoc
  • b80ba08: 8329967: Build failure after JDK-8329628
  • 4bba445: 8325659: Normalize Random usage by incubator vector tests
  • ... and 101 more: https://git.openjdk.org/jdk/compare/866e7b6b7745928e559da8cdf622bf6a097ec995...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 10, 2024
@openjdk openjdk bot closed this Apr 10, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Apr 10, 2024
@openjdk
Copy link

openjdk bot commented Apr 10, 2024

@offamitkumar @sid8606 Pushed as commit e0fd6c4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
3 participants