Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8258804: Collection.toArray() should use empty array #1861

Closed
wants to merge 1 commit into from

Conversation

@XueleiFan
Copy link
Member

@XueleiFan XueleiFan commented Dec 21, 2020

Comparing to Collection.toArray(new T[size)), the Collection.toArray(new T[0]) seems faster, safer and contractually cleaner. In the update, the use of Collection.toArray(new T[size)) in the SunJSSE provider implementation is replaced with Collection.toArray(new T[0]).

Bug: https://bugs.openjdk.java.net/browse/JDK-8258804


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8258804: Collection.toArray() should use empty array

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1861/head:pull/1861
$ git checkout pull/1861

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 21, 2020

👋 Welcome back xuelei! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Dec 21, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 21, 2020

@XueleiFan The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the security label Dec 21, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 22, 2020

Webrevs

Loading

Copy link
Member

@seanjmullan seanjmullan left a comment

Looks fine to me.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Dec 22, 2020

@XueleiFan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8258804: Collection.toArray() should use empty array

Reviewed-by: mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • 9e463d1: 8258631: Remove sun.security.jgss.krb5.Krb5Util.getSubject()
  • 0849117: 8256431: [PPC64] Implement Base64 encodeBlock() for Power64-LE
  • 172af15: 8258284: clean up issues with nested ThreadsListHandles
  • 3df6ec2: 8258682: compiler/intrinsics/mathexact/sanity tests fail with RepeatCompilation
  • 1594372: 8258584: java/util/HexFormat/HexFormatTest.java fails on x86_32

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Dec 22, 2020
@@ -851,7 +851,7 @@ private static void populate(String propname,
} else {
// Use the customized TLS protocols.
candidates =
refactored.toArray(new ProtocolVersion[refactored.size()]);
refactored.toArray(new ProtocolVersion[0]);
Copy link
Contributor

@dmlloyd dmlloyd Dec 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this level of performance improvement is justified, then would it not be better to use a constant empty array instead of constructing a new one each time?

Loading

Copy link
Member Author

@XueleiFan XueleiFan Dec 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think empty array construction could be optimized in the compiler layer.

Loading

@XueleiFan
Copy link
Member Author

@XueleiFan XueleiFan commented Dec 22, 2020

/integrate

Loading

@openjdk openjdk bot closed this Dec 22, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Dec 22, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 22, 2020

@XueleiFan Since your change was applied there have been 5 commits pushed to the master branch:

  • 9e463d1: 8258631: Remove sun.security.jgss.krb5.Krb5Util.getSubject()
  • 0849117: 8256431: [PPC64] Implement Base64 encodeBlock() for Power64-LE
  • 172af15: 8258284: clean up issues with nested ThreadsListHandles
  • 3df6ec2: 8258682: compiler/intrinsics/mathexact/sanity tests fail with RepeatCompilation
  • 1594372: 8258584: java/util/HexFormat/HexFormatTest.java fails on x86_32

Your commit was automatically rebased without conflicts.

Pushed as commit 39e03a0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@XueleiFan XueleiFan deleted the JDK-8258804 branch Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants