8329559: Test javax/swing/JFrame/bug4419914.java failed because The End and Start buttons are not placed correctly and Tab focus does not move as expected

[prsadhuk]

Test issue shows the End and Start buttons are not placed as per instructions due to ComponentOrientation RTL was not honoured, as with getContentPane() being removed from add call of JFrame, it was also additionally removed from other JFrame calls which resulted in the RTL not being propagated to its child. Fix is to add getContentPane() to the non-add methods of JFrame as was done in the applet version of the test..

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8329559: Test javax/swing/JFrame/bug4419914.java failed because The End and Start buttons are not placed correctly and Tab focus does not move as expected (Bug - P4)

Reviewers

• Abhishek Kumar (@kumarabhi006 - Committer)
• Harshitha Onkar (@honkar-jdk - Reviewer)
• Damon Nguyen (@DamonGuy - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18612/head:pull/18612
$ git checkout pull/18612

Update a local copy of the PR:
$ git checkout pull/18612
$ git pull https://git.openjdk.org/jdk.git pull/18612/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18612

View PR using the GUI difftool:
$ git pr show -t 18612

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18612.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8329559: Test javax/swing/JFrame/bug4419914.java failed because The End and Start buttons are not placed correctly and Tab focus does not move as expected

Reviewed-by: abhiscxk, honkar, dnguyen

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 264 new commits pushed to the master branch:

• 83c74d7: 8329717: Missing @since tags in elements in DocumentationTool and Taglet
• 0b9350e: 8322992: Javac fails with StackOverflowError when compiling deeply nested synchronized blocks
• 20be5e0: 8314846: Do not store Klass::_secondary_super_cache in CDS archive
• 7e421ce: 8330585: Refactor/rename forwardee handling
• 3e65d90: 8330820: Remove remnants of operator_new.cpp in build system
• 936a47d: 8330607: Deprecate -XX:+UseEmptySlotsInSupers
• ee7b2e9: 8330051: Small ObjectMonitor spinning code cleanups
• 3e185c7: 8330154: Serial: Remove TenuredSpace::update_for_block
• f889797: 8330463: Rename invalidate() to write_region() in ModRefBarrierSet
• c4f5c51: 8330576: ZYoungCompactionLimit should have range check
• ... and 254 more: https://git.openjdk.org/jdk/compare/866e7b6b7745928e559da8cdf622bf6a097ec995...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@prsadhuk The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (79123987)
• 00: Full (61a0a049)

[kumarabhi006]

Just a minor suggestion, can increase the row count to avoid the scrollbar else looks good to me.

[honkar-jdk]

LGTM

[DamonGuy]

Changes LGTM. Behaving as expected.

[prsadhuk]

/integrate

[openjdk]

Going to push as commit 7c1fad4.
Since your change was applied there have been 431 commits pushed to the master branch:

• 6bef047: 8272364: Parallel GC adaptive size policy may shrink the heap below MinHeapSize
• 01125fa: 8331605: jdk/test/lib/TestMutuallyExclusivePlatformPredicates.java test failure
• 04271df: 8331331: :tier1 target explanation in doc/testing.md is incorrect
• f6cdcc6: 8280988: [XWayland] Click on title to request focus test failures
• 99654ec: 8331516: Tests should not use the "Classpath" exception form of the legal header
• cd3a607: 8328864: NullPointerException in sun.security.jca.ProviderList.getService()
• 73cdc9a: 8326421: Add jtreg test for large arrayCopy disjoint case.
• e2c0cfe: 8331320: ClassFile API OutOfMemoryError with certain class files
• 6f98d8f: 8329692: Add more details to FrameStateTest.java test instructions
• 6969a9e: 8328999: Update GIFlib to 5.2.2
• ... and 421 more: https://git.openjdk.org/jdk/compare/866e7b6b7745928e559da8cdf622bf6a097ec995...master

Your commit was automatically rebased without conflicts.

[openjdk]

@prsadhuk Pushed as commit 7c1fad4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.