Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8329637: Apparent typo in java.security file property jdk.tls.keyLimits #18613

Closed
wants to merge 1 commit into from

Conversation

bradfordwetmore
Copy link
Contributor

@bradfordwetmore bradfordwetmore commented Apr 4, 2024

Fix a minor typo in the java.security file that got missed during the original TLSv1.3 work.

No test needed, comments only.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change requires CSR request JDK-8329642 to be approved
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-8329637: Apparent typo in java.security file property jdk.tls.keyLimits (Bug - P4)
  • JDK-8329642: Apparent typo in java.security file property jdk.tls.keyLimits (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18613/head:pull/18613
$ git checkout pull/18613

Update a local copy of the PR:
$ git checkout pull/18613
$ git pull https://git.openjdk.org/jdk.git pull/18613/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18613

View PR using the GUI difftool:
$ git pr show -t 18613

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18613.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 4, 2024

👋 Welcome back wetmore! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 4, 2024

@bradfordwetmore This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8329637: Apparent typo in java.security file property jdk.tls.keyLimits

Reviewed-by: ascarpino

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • 6382a12: 8326666: Remove the Java Management Extension (JMX) Subject Delegation feature
  • d90e5b5: 8329546: Assume sized integral types are available
  • f3db279: 8327410: Add hostname option for UL file names
  • 21867c9: 8313332: Simplify lazy jmethodID cache in InstanceKlass
  • b9da140: 8329594: G1: Consistent Titles to Thread Work Items.
  • a169c06: 8329580: Parallel: Remove VerifyObjectStartArray
  • 8efd7aa: 8328786: [AIX] move some important warnings/errors from trcVerbose to UL
  • f26e430: 8327110: Refactor create_bool_from_template_assertion_predicate() to separate class and fix identical cloning cases used for Loop Unswitching and Split If
  • e5e21a8: 8328702: C2: Crash during parsing because sub type check is not folded

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Apr 4, 2024

@bradfordwetmore The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label Apr 4, 2024
@bradfordwetmore bradfordwetmore marked this pull request as ready for review April 4, 2024 17:39
@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 4, 2024
@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 4, 2024
@mlbridge
Copy link

mlbridge bot commented Apr 4, 2024

Webrevs

@bradfordwetmore
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 4, 2024

Going to push as commit 4276d5c.
Since your change was applied there have been 9 commits pushed to the master branch:

  • 6382a12: 8326666: Remove the Java Management Extension (JMX) Subject Delegation feature
  • d90e5b5: 8329546: Assume sized integral types are available
  • f3db279: 8327410: Add hostname option for UL file names
  • 21867c9: 8313332: Simplify lazy jmethodID cache in InstanceKlass
  • b9da140: 8329594: G1: Consistent Titles to Thread Work Items.
  • a169c06: 8329580: Parallel: Remove VerifyObjectStartArray
  • 8efd7aa: 8328786: [AIX] move some important warnings/errors from trcVerbose to UL
  • f26e430: 8327110: Refactor create_bool_from_template_assertion_predicate() to separate class and fix identical cloning cases used for Loop Unswitching and Split If
  • e5e21a8: 8328702: C2: Crash during parsing because sub type check is not folded

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 4, 2024
@openjdk openjdk bot closed this Apr 4, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 4, 2024
@openjdk
Copy link

openjdk bot commented Apr 4, 2024

@bradfordwetmore Pushed as commit 4276d5c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated security security-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

2 participants