Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8329322 : Convert PageFormat/Orient.java to use PassFailJFrame #18624

Closed
wants to merge 3 commits into from

Conversation

Renjithkannath
Copy link
Contributor

@Renjithkannath Renjithkannath commented Apr 4, 2024

Hi Reviewers,

I have updated the test with PassFailJFrame along with printer availability check. Please review and let me know your suggestions.

Renjith.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8329322: Convert PageFormat/Orient.java to use PassFailJFrame (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18624/head:pull/18624
$ git checkout pull/18624

Update a local copy of the PR:
$ git checkout pull/18624
$ git pull https://git.openjdk.org/jdk.git pull/18624/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18624

View PR using the GUI difftool:
$ git pr show -t 18624

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18624.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 4, 2024

👋 Welcome back rkannathpari! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 4, 2024

@Renjithkannath This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8329322: Convert PageFormat/Orient.java to use PassFailJFrame

Reviewed-by: abhiscxk, aivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 197 new commits pushed to the master branch:

  • 4b55fe5: 8330520: linux clang build fails in os_linux.cpp with static_assert with no message is a C++17 extension
  • 5eb2c59: 8330475: Remove unused default value for ModRefBarrierSet::write_ref_array_pre
  • 003e86f: 8324755: Enable parallelism in vmTestbase/gc/gctests/LargeObjects tests
  • 706b421: 8330467: NoClassDefFoundError when lambda is in a hidden class
  • fe0227e: 8311098: Change comment in verificationType.hpp to refer to _sym
  • 0646284: 8317376: Minor improvements to the 'this' escape analyzer
  • 4895a15: 8319516: AIX System::loadLibrary needs support to load a shared library from an archive object
  • fd331ff: 8325469: Freeze/Thaw code can crash in the presence of OSR frames
  • 9fd7802: 8325494: C2: Broken graph after not skipping CastII node anymore for Assertion Predicates after JDK-8309902
  • 192ec38: 8329595: spurious variable "might not have been initialized" on static final field
  • ... and 187 more: https://git.openjdk.org/jdk/compare/b9da14012da5f1f72d4f6e690c18a43e87523173...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@TejeshR13, @kumarabhi006, @aivanov-jdk) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk
Copy link

openjdk bot commented Apr 4, 2024

@Renjithkannath The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Apr 4, 2024
@Renjithkannath Renjithkannath changed the title JDK-8329322:Convert PageFormat/Orient.java to use PassFailJFrame 8329322 : Convert PageFormat/Orient.java to use PassFailJFrame Apr 4, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 4, 2024
@mlbridge
Copy link

mlbridge bot commented Apr 4, 2024

Webrevs

Copy link
Contributor

@TejeshR13 TejeshR13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you test it for other L&F also?

"Axes will indicate the direction of increasing X and Y\n\n" +
"Test failed if the oval on the page clipped against the imageable area.";

private static void init() throws PrinterException {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

init() can be renamed since the test is no longer applet based.

Sysout.printInstructions( instructions );

private static final String INSTRUCTIONS =
"This test will automatically initiate a print.\n\n" +
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can use Text Block style for better readability.

String INSTRUCTIONS = """
...""".

* @test
* @bug 4236095
* @summary Confirm that you get three pages of output, one
* each in portrait, landscape, and reverse landscape
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* each in portrait, landscape, and reverse landscape
* each in portrait, landscape and reverse landscape

@kumarabhi006
Copy link
Contributor

Is there any way we can test it with "print to pdf" option or physical printer is must?

@Renjithkannath
Copy link
Contributor Author

Yes this will work on Print to pdf, I don't think physical printer is must.

@kumarabhi006
Copy link
Contributor

Yes this will work on Print to pdf, I don't think physical printer is must.

I am getting this dialog message "Printer status is not available at this time."

@Renjithkannath
Copy link
Contributor Author

Its working for me, please make sure you have configured pdf printer as your default printer. In this test there is no option to select printer.

@kumarabhi006
Copy link
Contributor

Its working for me, please make sure you have configured pdf printer as your default printer. In this test there is no option to select printer.

Yeah... default was set to physical printer which is currently inaccessible. Working fine for me also.

Copy link
Contributor

@kumarabhi006 kumarabhi006 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 17, 2024
@Renjithkannath
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Apr 18, 2024
@openjdk
Copy link

openjdk bot commented Apr 18, 2024

@Renjithkannath
Your change (at version fcf3830) is now ready to be sponsored by a Committer.

@aivanov-jdk
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Apr 18, 2024

Going to push as commit f713766.
Since your change was applied there have been 203 commits pushed to the master branch:

  • ec180d4: 8324950: IGV: save the state to a file
  • 571e6bc: 8330419: Unused code in ConnectionGraph::specialize_castpp
  • 5853a2c: 8330533: JFR: LocalDateTime should not use milliseconds since epoch
  • b648ed0: 8329997: Add provisions for checking memory segment alignment constraints
  • 60b65e6: 8325872: Make GuaranteedSafepointInterval default 0
  • b049609: 8330094: RISC-V: Save and restore FRM in the call stub
  • 4b55fe5: 8330520: linux clang build fails in os_linux.cpp with static_assert with no message is a C++17 extension
  • 5eb2c59: 8330475: Remove unused default value for ModRefBarrierSet::write_ref_array_pre
  • 003e86f: 8324755: Enable parallelism in vmTestbase/gc/gctests/LargeObjects tests
  • 706b421: 8330467: NoClassDefFoundError when lambda is in a hidden class
  • ... and 193 more: https://git.openjdk.org/jdk/compare/b9da14012da5f1f72d4f6e690c18a43e87523173...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 18, 2024
@openjdk openjdk bot closed this Apr 18, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Apr 18, 2024
@openjdk
Copy link

openjdk bot commented Apr 18, 2024

@aivanov-jdk @Renjithkannath Pushed as commit f713766.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

4 participants