8329322 : Convert PageFormat/Orient.java to use PassFailJFrame #18624

Renjithkannath · 2024-04-04T12:07:46Z

Hi Reviewers,

I have updated the test with PassFailJFrame along with printer availability check. Please review and let me know your suggestions.

Renjith.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8329322: Convert PageFormat/Orient.java to use PassFailJFrame (Bug - P4)

Reviewers

Abhishek Kumar (@kumarabhi006 - Committer)
Alexey Ivanov (@aivanov-jdk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18624/head:pull/18624
$ git checkout pull/18624

Update a local copy of the PR:
$ git checkout pull/18624
$ git pull https://git.openjdk.org/jdk.git pull/18624/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18624

View PR using the GUI difftool:
$ git pr show -t 18624

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18624.diff

Webrev

Link to Webrev Comment

bridgekeeper · 2024-04-04T12:08:40Z

👋 Welcome back rkannathpari! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2024-04-04T12:09:08Z

@Renjithkannath This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8329322: Convert PageFormat/Orient.java to use PassFailJFrame

Reviewed-by: abhiscxk, aivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 197 new commits pushed to the master branch:

4b55fe5: 8330520: linux clang build fails in os_linux.cpp with static_assert with no message is a C++17 extension
5eb2c59: 8330475: Remove unused default value for ModRefBarrierSet::write_ref_array_pre
003e86f: 8324755: Enable parallelism in vmTestbase/gc/gctests/LargeObjects tests
706b421: 8330467: NoClassDefFoundError when lambda is in a hidden class
fe0227e: 8311098: Change comment in verificationType.hpp to refer to _sym
0646284: 8317376: Minor improvements to the 'this' escape analyzer
4895a15: 8319516: AIX System::loadLibrary needs support to load a shared library from an archive object
fd331ff: 8325469: Freeze/Thaw code can crash in the presence of OSR frames
9fd7802: 8325494: C2: Broken graph after not skipping CastII node anymore for Assertion Predicates after JDK-8309902
192ec38: 8329595: spurious variable "might not have been initialized" on static final field
... and 187 more: https://git.openjdk.org/jdk/compare/b9da14012da5f1f72d4f6e690c18a43e87523173...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@TejeshR13, @kumarabhi006, @aivanov-jdk) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

openjdk · 2024-04-04T12:09:21Z

@Renjithkannath The following label will be automatically applied to this pull request:

client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2024-04-04T12:13:17Z

Webrevs

01: Full - Incremental (fcf3830a)
00: Full (e151b4ca)

TejeshR13

Did you test it for other L&F also?

TejeshR13 · 2024-04-08T05:45:56Z

test/jdk/java/awt/print/PageFormat/Orient.java

+            "Axes will indicate the direction of increasing X and Y\n\n" +
+            "Test failed if the oval on the page clipped against the imageable area.";
+
+    private static void init() throws PrinterException {


init() can be renamed since the test is no longer applet based.

kumarabhi006 · 2024-04-08T05:50:59Z

test/jdk/java/awt/print/PageFormat/Orient.java

-      Sysout.printInstructions( instructions );
-
+    private static final String INSTRUCTIONS =
+            "This test will automatically initiate a print.\n\n" +


Can use Text Block style for better readability.

String INSTRUCTIONS = """
...""".

kumarabhi006 · 2024-04-08T05:51:15Z

test/jdk/java/awt/print/PageFormat/Orient.java

+ * @test
+ * @bug 4236095
+ * @summary  Confirm that you get three pages of output, one
+ *           each in portrait, landscape, and reverse landscape


Suggested change

* each in portrait, landscape, and reverse landscape

* each in portrait, landscape and reverse landscape

kumarabhi006 · 2024-04-10T11:46:35Z

Is there any way we can test it with "print to pdf" option or physical printer is must?

Renjithkannath · 2024-04-12T04:30:34Z

Yes this will work on Print to pdf, I don't think physical printer is must.

kumarabhi006 · 2024-04-12T05:04:54Z

Yes this will work on Print to pdf, I don't think physical printer is must.

I am getting this dialog message "Printer status is not available at this time."

Renjithkannath · 2024-04-12T05:15:53Z

Its working for me, please make sure you have configured pdf printer as your default printer. In this test there is no option to select printer.

kumarabhi006 · 2024-04-12T05:33:41Z

Its working for me, please make sure you have configured pdf printer as your default printer. In this test there is no option to select printer.

Yeah... default was set to physical printer which is currently inaccessible. Working fine for me also.

kumarabhi006

LGTM.

Renjithkannath · 2024-04-18T10:46:50Z

/integrate

openjdk · 2024-04-18T10:48:14Z

@Renjithkannath
Your change (at version fcf3830) is now ready to be sponsored by a Committer.

aivanov-jdk · 2024-04-18T13:32:18Z

/sponsor

openjdk · 2024-04-18T13:32:37Z

Going to push as commit f713766.
Since your change was applied there have been 203 commits pushed to the master branch:

ec180d4: 8324950: IGV: save the state to a file
571e6bc: 8330419: Unused code in ConnectionGraph::specialize_castpp
5853a2c: 8330533: JFR: LocalDateTime should not use milliseconds since epoch
b648ed0: 8329997: Add provisions for checking memory segment alignment constraints
60b65e6: 8325872: Make GuaranteedSafepointInterval default 0
b049609: 8330094: RISC-V: Save and restore FRM in the call stub
4b55fe5: 8330520: linux clang build fails in os_linux.cpp with static_assert with no message is a C++17 extension
5eb2c59: 8330475: Remove unused default value for ModRefBarrierSet::write_ref_array_pre
003e86f: 8324755: Enable parallelism in vmTestbase/gc/gctests/LargeObjects tests
706b421: 8330467: NoClassDefFoundError when lambda is in a hidden class
... and 193 more: https://git.openjdk.org/jdk/compare/b9da14012da5f1f72d4f6e690c18a43e87523173...master

Your commit was automatically rebased without conflicts.

openjdk · 2024-04-18T13:32:43Z

@aivanov-jdk @Renjithkannath Pushed as commit f713766.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

JDK-8329322:Convert PageFormat/Orient.java to use PassFailJFrame

e151b4c

openjdk bot added the client client-libs-dev@openjdk.org label Apr 4, 2024

Renjithkannath changed the title ~~JDK-8329322:Convert PageFormat/Orient.java to use PassFailJFrame~~ 8329322 : Convert PageFormat/Orient.java to use PassFailJFrame Apr 4, 2024

openjdk bot added the rfr Pull request is ready for review label Apr 4, 2024

TejeshR13 reviewed Apr 8, 2024

View reviewed changes

kumarabhi006 reviewed Apr 8, 2024

View reviewed changes

Renjithkannath added 2 commits April 8, 2024 12:56

Updated suggesions

2650f88

Updated insturction style

fcf3830

kumarabhi006 approved these changes Apr 12, 2024

View reviewed changes

aivanov-jdk approved these changes Apr 17, 2024

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Apr 17, 2024

openjdk bot added the sponsor Pull request is ready to be sponsored label Apr 18, 2024

openjdk bot added the integrated Pull request has been integrated label Apr 18, 2024

openjdk bot closed this Apr 18, 2024

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Apr 18, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8329322 : Convert PageFormat/Orient.java to use PassFailJFrame #18624

8329322 : Convert PageFormat/Orient.java to use PassFailJFrame #18624

Renjithkannath commented Apr 4, 2024 •

edited by openjdk bot

Loading

bridgekeeper bot commented Apr 4, 2024

openjdk bot commented Apr 4, 2024 •

edited

Loading

openjdk bot commented Apr 4, 2024

mlbridge bot commented Apr 4, 2024 •

edited

Loading

TejeshR13 left a comment

TejeshR13 Apr 8, 2024

kumarabhi006 Apr 8, 2024

kumarabhi006 Apr 8, 2024

kumarabhi006 commented Apr 10, 2024

Renjithkannath commented Apr 12, 2024

kumarabhi006 commented Apr 12, 2024

Renjithkannath commented Apr 12, 2024

kumarabhi006 commented Apr 12, 2024

kumarabhi006 left a comment

Renjithkannath commented Apr 18, 2024

openjdk bot commented Apr 18, 2024

aivanov-jdk commented Apr 18, 2024

openjdk bot commented Apr 18, 2024

openjdk bot commented Apr 18, 2024

	* each in portrait, landscape, and reverse landscape
	* each in portrait, landscape and reverse landscape

8329322 : Convert PageFormat/Orient.java to use PassFailJFrame #18624

8329322 : Convert PageFormat/Orient.java to use PassFailJFrame #18624

Conversation

Renjithkannath commented Apr 4, 2024 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

Webrev

bridgekeeper bot commented Apr 4, 2024

openjdk bot commented Apr 4, 2024 • edited Loading

openjdk bot commented Apr 4, 2024

mlbridge bot commented Apr 4, 2024 • edited Loading

Webrevs

TejeshR13 left a comment

Choose a reason for hiding this comment

TejeshR13 Apr 8, 2024

Choose a reason for hiding this comment

kumarabhi006 Apr 8, 2024

Choose a reason for hiding this comment

kumarabhi006 Apr 8, 2024

Choose a reason for hiding this comment

kumarabhi006 commented Apr 10, 2024

Renjithkannath commented Apr 12, 2024

kumarabhi006 commented Apr 12, 2024

Renjithkannath commented Apr 12, 2024

kumarabhi006 commented Apr 12, 2024

kumarabhi006 left a comment

Choose a reason for hiding this comment

Renjithkannath commented Apr 18, 2024

openjdk bot commented Apr 18, 2024

aivanov-jdk commented Apr 18, 2024

openjdk bot commented Apr 18, 2024

openjdk bot commented Apr 18, 2024

Renjithkannath commented Apr 4, 2024 •

edited by openjdk bot

Loading

openjdk bot commented Apr 4, 2024 •

edited

Loading

mlbridge bot commented Apr 4, 2024 •

edited

Loading