Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8258631: Remove sun.security.jgss.krb5.Krb5Util.getSubject() #1865

Closed
wants to merge 1 commit into from

Conversation

wangweij
Copy link
Contributor

@wangweij wangweij commented Dec 22, 2020

The method is useless now since the related TLS cipher suite was removed long ago.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8258631: Remove sun.security.jgss.krb5.Krb5Util.getSubject()

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1865/head:pull/1865
$ git checkout pull/1865

8258631: Remove sun.security.jgss.krb5.Krb5Util.getSubject()
@bridgekeeper
Copy link

bridgekeeper bot commented Dec 22, 2020

👋 Welcome back weijun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 22, 2020
@openjdk
Copy link

openjdk bot commented Dec 22, 2020

@wangweij The following labels will be automatically applied to this pull request:

  • core-libs
  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added security security-dev@openjdk.org core-libs core-libs-dev@openjdk.org labels Dec 22, 2020
@mlbridge
Copy link

mlbridge bot commented Dec 22, 2020

Webrevs

@AlanBateman
Copy link
Contributor

AlanBateman commented Dec 22, 2020

/label remove core-libs

@openjdk openjdk bot removed the core-libs core-libs-dev@openjdk.org label Dec 22, 2020
@openjdk
Copy link

openjdk bot commented Dec 22, 2020

@AlanBateman
The core-libs label was successfully removed.

@wangweij
Copy link
Contributor Author

wangweij commented Dec 22, 2020

/label remove core-libs

Oops, openjdk/skara#980 filed.

@XueleiFan
Copy link
Member

XueleiFan commented Dec 22, 2020

Looks good to me.

@openjdk
Copy link

openjdk bot commented Dec 22, 2020

@wangweij This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8258631: Remove sun.security.jgss.krb5.Krb5Util.getSubject()

Reviewed-by: xuelei

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 22, 2020
@wangweij
Copy link
Contributor Author

wangweij commented Dec 22, 2020

/integrate

@openjdk openjdk bot closed this Dec 22, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 22, 2020
@openjdk
Copy link

openjdk bot commented Dec 22, 2020

@wangweij Pushed as commit 9e463d1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@wangweij wangweij deleted the 8258631 branch Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated security security-dev@openjdk.org
3 participants