8329761: Remove unused KeyBuilder and unusedSets from StyleContext

[aivanov-jdk]

Remove unused class KeyBuilder and unused field unusedSets.
Update a comment which used javadoc syntax.
Mark KeyEnumeration and FontKey classes as final.

All the client tests are green.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8329761: Remove unused KeyBuilder and unusedSets from StyleContext (Bug - P4)

Reviewers

• Sergey Bylokhov (@mrserb - Reviewer)
• Tejesh R (@TejeshR13 - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18659/head:pull/18659
$ git checkout pull/18659

Update a local copy of the PR:
$ git checkout pull/18659
$ git pull https://git.openjdk.org/jdk.git pull/18659/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18659

View PR using the GUI difftool:
$ git pr show -t 18659

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18659.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back aivanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@aivanov-jdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8329761: Remove unused KeyBuilder and unusedSets from StyleContext

Reviewed-by: serb, tr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

• 51b0abc: 8329340: Remove unused libawt code
• 3a3b77d: 8329641: RISC-V: Enable some tests related to SHA-2 instrinsic
• d771ec6: 8329733: Update the documentation in java.net.SocketOptions to direct to java.net.StandardSocketOptions
• 49d8e63: 8329083: RISC-V: Update profiles supported on riscv
• 3d50eaa: 8329784: Run MaxMetaspaceSizeTest.java with -Xshare:off
• 862e615: 8198237: [macos] Test java/awt/Frame/ExceptionOnSetExtendedStateTest/ExceptionOnSetExtendedStateTest.java fails
• 040c935: 8328183: Minor mistakes in docs of PrintStream.append()
• 4a11db8: 8329662: Add a test to verify the behaviour of the default HEAD() method on HttpRequest.Builder
• 46d3d7b: 8329529: Serial: Move _saved_mark_word out of ContiguousSpace
• 29992e1: 8329570: G1: Excessive is_obj_dead_cond calls in verification
• ... and 1 more: https://git.openjdk.org/jdk/compare/18c925cd33d6f3b1d4365d582dddaa8426f41bea...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@aivanov-jdk The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (ed8c3ce2)

[mrserb]

Could you please check the history of that file, is these unused due to some functionality was deleted and this was missed, or we planned to implement something and forgot?

[aivanov-jdk]

Could you please check the history of that file, is these unused due to some functionality was deleted and this was missed, or we planned to implement something and forgot?

Both were used in pre-historic days.

The unusedSets field tracked the number of unused attribute sets passed to the reclaim method. It's been unused since attributePool became WeakHashMap.

The KeyBuilder was used for searching… The search field was an instance of KeyBuilder.

[aivanov-jdk]

/integrate

[openjdk]

Going to push as commit a48289a.
Since your change was applied there have been 37 commits pushed to the master branch:

• 8907eda: 8325485: IncrementInstructions.of(int, int) is not storing the args
• b9331cd: 8329823: RISC-V: Need to sync CPU features with related JVM flags
• 71c5bbc: 8329527: Opcode.IFNONNULL.primaryTypeKind() is not ReferenceType
• 58e39c1: 8329884: Serial: Fix build failure due to ‘Copy’ has not been declared
• 19a99d0: 8326744: Class-File API transition to Second Preview
• b4dddde: 8329840: Fix ZPhysicalMemorySegment::_end type
• dfaf11a: 8329898: Revert one use of markWord.is_unlocked back to is_neutral
• fbc1e66: 8328181: C2: assert(MaxVectorSize >= 32) failed: vector length should be >= 32
• a887fd2: 8316991: Reduce nullable allocation merges
• e702646: 8200566: DistributionPointFetcher fails to fetch CRLs if the DistributionPoints field contains more than one DistributionPoint and the first one fails
• ... and 27 more: https://git.openjdk.org/jdk/compare/18c925cd33d6f3b1d4365d582dddaa8426f41bea...master

Your commit was automatically rebased without conflicts.

[openjdk]

@aivanov-jdk Pushed as commit a48289a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.