8329659: Serial: Extract allowed_dead_ratio from ContiguousSpace

[lgxbslgx]

Hi all,

This patch moves the allowed_dead_ratio related content from ContiguousSpace to DeadSpacer.

The tests make test-tier1_gc passed locally. Thanks for taking the time to review.

Best Regards,
-- Guoxiong

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8329659: Serial: Extract allowed_dead_ratio from ContiguousSpace (Enhancement - P4)

Reviewers

• Albert Mingkun Yang (@albertnetymk - Reviewer)
• Ivan Walulya (@walulyai - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18661/head:pull/18661
$ git checkout pull/18661

Update a local copy of the PR:
$ git checkout pull/18661
$ git pull https://git.openjdk.org/jdk.git pull/18661/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18661

View PR using the GUI difftool:
$ git pr show -t 18661

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18661.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back gli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@lgxbslgx This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8329659: Serial: Extract allowed_dead_ratio from ContiguousSpace

Reviewed-by: ayang, iwalulya

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

• 7475824: 8329510: Update ProblemList for JFileChooser/8194044/FileSystemRootTest.java
• 6439375: 8329533: TestCDSVMCrash fails on libgraal
• 3ebf8c9: 8329663: hs_err file event log entry for thread adding/removing should print current thread
• be45de1: 8328627: JShell documentation should be clearer about "remote runtime system"
• 8648890: 8329749: Obsolete the unused UseNeon flag
• fc18201: 8327111: Replace remaining usage of create_bool_from_template_assertion_predicate() which requires additional OpaqueLoop*Nodes transformation strategies
• 7c66465: 8325088: Overloads that differ in type parameters may be lost
• 6f087cb: 8328698: oopDesc::klass_raw() decodes without a null check
• d1aad71: 8321204: C2: assert(false) failed: node should be in igvn hash table
• 51b0abc: 8329340: Remove unused libawt code
• ... and 7 more: https://git.openjdk.org/jdk/compare/46d3d7b9673e06c74c8586c164f8a233a8876835...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@lgxbslgx The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (e51d30c2)
• 00: Full (19bb8e87)

[albertnetymk]

How about

    size_t ratio = (_space == SerialHeap::heap()->old_gen()->space())
                 ? MarkSweepDeadRatio
                 : 0;

?

[lgxbslgx]

If each space have a allowed_dead_ratio, it is easy to modify one of them and meet the changeable demand in the future. But these years, we rarely have a demand to revise them. Maybe the previous code and this current patch are both over-designed. Fixed just as you suggested.

[lgxbslgx]

@albertnetymk @walulyai Thanks for your reviews.

/integrate

[openjdk]

Going to push as commit 115f419.
Since your change was applied there have been 18 commits pushed to the master branch:

• 9ac3b77: 8329775: Serial: Remove unused declarations in serialFullGC.hpp
• 7475824: 8329510: Update ProblemList for JFileChooser/8194044/FileSystemRootTest.java
• 6439375: 8329533: TestCDSVMCrash fails on libgraal
• 3ebf8c9: 8329663: hs_err file event log entry for thread adding/removing should print current thread
• be45de1: 8328627: JShell documentation should be clearer about "remote runtime system"
• 8648890: 8329749: Obsolete the unused UseNeon flag
• fc18201: 8327111: Replace remaining usage of create_bool_from_template_assertion_predicate() which requires additional OpaqueLoop*Nodes transformation strategies
• 7c66465: 8325088: Overloads that differ in type parameters may be lost
• 6f087cb: 8328698: oopDesc::klass_raw() decodes without a null check
• d1aad71: 8321204: C2: assert(false) failed: node should be in igvn hash table
• ... and 8 more: https://git.openjdk.org/jdk/compare/46d3d7b9673e06c74c8586c164f8a233a8876835...master

Your commit was automatically rebased without conflicts.

[openjdk]

@lgxbslgx Pushed as commit 115f419.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.