8329840: Fix ZPhysicalMemorySegment::_end type

[xmas92]

ZPhysicalMemorySegment::_end should use zoffset_end for its type instead of zoffset.

Starting a debug vm with a 16TB min heap size will crash with an invalid zoffset assert.

Testing with ZGC tier1-tier7 on linux x64+aarch64

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8329840: Fix ZPhysicalMemorySegment::_end type (Bug - P4)

Reviewers

• Stefan Karlsson (@stefank - Reviewer)
• Erik Österlund (@fisk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18673/head:pull/18673
$ git checkout pull/18673

Update a local copy of the PR:
$ git checkout pull/18673
$ git pull https://git.openjdk.org/jdk.git pull/18673/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18673

View PR using the GUI difftool:
$ git pr show -t 18673

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18673.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back aboldtch! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@xmas92 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8329840: Fix ZPhysicalMemorySegment::_end type

Reviewed-by: stefank, eosterlund

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 56 new commits pushed to the master branch:

• fbc1e66: 8328181: C2: assert(MaxVectorSize >= 32) failed: vector length should be >= 32
• a887fd2: 8316991: Reduce nullable allocation merges
• e702646: 8200566: DistributionPointFetcher fails to fetch CRLs if the DistributionPoints field contains more than one DistributionPoint and the first one fails
• 7e5ef79: 8323116: [REDO] Computational test more than 2x slower when AVX instructions are used
• 9467720: 8329875: Serial: Move preservedMarks.inline.hpp to serialFullGC.cpp
• a4dd2e9: 8329766: Serial: Refactor SerialBlockOffsetTable API
• 212a253: 8329623: NegativeArraySizeException encoding large String to UTF-8
• dd930c5: 8329787: Fix typo in CLDRConverter
• 115f419: 8329659: Serial: Extract allowed_dead_ratio from ContiguousSpace
• 9ac3b77: 8329775: Serial: Remove unused declarations in serialFullGC.hpp
• ... and 46 more: https://git.openjdk.org/jdk/compare/8efd7aa6c1671fa7d40c5c43bed140a493cfcf72...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@xmas92 The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (ae3160d4)
• 00: Full (60bf14ee)

[fisk]

Looks good.

[xmas92]

Thanks for the reviews.
/integrate

[openjdk]

Going to push as commit b4dddde.
Since your change was applied there have been 57 commits pushed to the master branch:

• dfaf11a: 8329898: Revert one use of markWord.is_unlocked back to is_neutral
• fbc1e66: 8328181: C2: assert(MaxVectorSize >= 32) failed: vector length should be >= 32
• a887fd2: 8316991: Reduce nullable allocation merges
• e702646: 8200566: DistributionPointFetcher fails to fetch CRLs if the DistributionPoints field contains more than one DistributionPoint and the first one fails
• 7e5ef79: 8323116: [REDO] Computational test more than 2x slower when AVX instructions are used
• 9467720: 8329875: Serial: Move preservedMarks.inline.hpp to serialFullGC.cpp
• a4dd2e9: 8329766: Serial: Refactor SerialBlockOffsetTable API
• 212a253: 8329623: NegativeArraySizeException encoding large String to UTF-8
• dd930c5: 8329787: Fix typo in CLDRConverter
• 115f419: 8329659: Serial: Extract allowed_dead_ratio from ContiguousSpace
• ... and 47 more: https://git.openjdk.org/jdk/compare/8efd7aa6c1671fa7d40c5c43bed140a493cfcf72...master

Your commit was automatically rebased without conflicts.

[openjdk]

@xmas92 Pushed as commit b4dddde.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[mmyxym]

/backport jdk21u-dev

[openjdk]

@mmyxym the backport was successfully created on the branch backport-mmyxym-b4ddddef in my personal fork of openjdk/jdk21u-dev. To create a pull request with this backport targeting openjdk/jdk21u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit b4ddddef from the openjdk/jdk repository.

The commit being backported was authored by Axel Boldt-Christmas on 9 Apr 2024 and was reviewed by Stefan Karlsson and Erik Österlund.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk21u-dev:

$ git fetch https://github.com/openjdk-bots/jdk21u-dev.git backport-mmyxym-b4ddddef:backport-mmyxym-b4ddddef
$ git checkout backport-mmyxym-b4ddddef
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk21u-dev.git backport-mmyxym-b4ddddef

[mmyxym]

/backport jdk22u

[openjdk]

@mmyxym the backport was successfully created on the branch backport-mmyxym-b4ddddef in my personal fork of openjdk/jdk22u. To create a pull request with this backport targeting openjdk/jdk22u:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit b4ddddef from the openjdk/jdk repository.

The commit being backported was authored by Axel Boldt-Christmas on 9 Apr 2024 and was reviewed by Stefan Karlsson and Erik Österlund.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk22u:

$ git fetch https://github.com/openjdk-bots/jdk22u.git backport-mmyxym-b4ddddef:backport-mmyxym-b4ddddef
$ git checkout backport-mmyxym-b4ddddef
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk22u.git backport-mmyxym-b4ddddef