8329636: Deprecate -XX:+PreserveAllAnnotations

[alexmenkov]

Tested

• tier1-3;
• test/jdk/java/lang/instrument/RetransformRecordAnnotation.java (the only test that uses the option)

CSR needs review as well

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change requires CSR request JDK-8329808 to be approved

Issues

• JDK-8329636: Deprecate -XX:+PreserveAllAnnotations (Enhancement - P4)
• JDK-8329808: Deprecate -XX:+PreserveAllAnnotations (CSR)

Reviewers

• Coleen Phillimore (@coleenp - Reviewer)
• David Holmes (@dholmes-ora - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18680/head:pull/18680
$ git checkout pull/18680

Update a local copy of the PR:
$ git checkout pull/18680
$ git pull https://git.openjdk.org/jdk.git pull/18680/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18680

View PR using the GUI difftool:
$ git pr show -t 18680

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18680.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back amenkov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@alexmenkov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8329636: Deprecate -XX:+PreserveAllAnnotations

Reviewed-by: coleenp, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 154 new commits pushed to the master branch:

• 76cbe48: 8329430: MetaspaceShared::preload_and_dump should clear pending exception
• f7c8413: 8326116: JFR: Add help option to -XX:StartFlightRecording
• 941bee1: 8327640: Allow NumberFormat strict parsing
• 2ede143: 8330279: Typo in java.text.Bidi class description
• 90df3b7: 8329190: (ch) DatagramChannel.receive should throw ClosedChannelException when called on closed channel
• f11a496: 8180450: secondary_super_cache does not scale well
• bfff02e: 8330165: C2: make superword consistently use PhaseIdealLoop::register_new_node()
• e073d5b: 8329665: fatal error: memory leak: allocating without ResourceMark
• 6e77d91: 8330261: Clean up linking steps
• 61fa4d4: 8330351: Remove the SHARED_LIBRARY and STATIC_LIBRARY macros
• ... and 144 more: https://git.openjdk.org/jdk/compare/e1183ac044f803bf0d4ccfebc2b1cd5b33294c7a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@alexmenkov The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (4df4ebbb)
• 00: Full (4513531f)

[coleenp]

There's a test that this option should be added to in VMDeprecatedOptions.java.

[coleenp]

Looks good. Now to see if there's any objection in the CSR.

[dholmes-ora]

Code changes are good - assuming CSR proceeds.

Thanks

[alexmenkov]

Coleen, David, thank you for the review.
The CSR is approved.
/integrate

[openjdk]

Going to push as commit fb4cf1c.
Since your change was applied there have been 155 commits pushed to the master branch:

• d1c6cd1: 8330133: libj2pkcs11.so crashes on some pkcs#11 v3.0 libraries
• 76cbe48: 8329430: MetaspaceShared::preload_and_dump should clear pending exception
• f7c8413: 8326116: JFR: Add help option to -XX:StartFlightRecording
• 941bee1: 8327640: Allow NumberFormat strict parsing
• 2ede143: 8330279: Typo in java.text.Bidi class description
• 90df3b7: 8329190: (ch) DatagramChannel.receive should throw ClosedChannelException when called on closed channel
• f11a496: 8180450: secondary_super_cache does not scale well
• bfff02e: 8330165: C2: make superword consistently use PhaseIdealLoop::register_new_node()
• e073d5b: 8329665: fatal error: memory leak: allocating without ResourceMark
• 6e77d91: 8330261: Clean up linking steps
• ... and 145 more: https://git.openjdk.org/jdk/compare/e1183ac044f803bf0d4ccfebc2b1cd5b33294c7a...master

Your commit was automatically rebased without conflicts.

[openjdk]

@alexmenkov Pushed as commit fb4cf1c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.