8188784: javax/management/notification/BroadcasterSupportDeadlockTest.java - TEST FAILED: deadlock

[kevinjwalls]

This test incorrectly fails, although rarely, thinking its "thread 2" has deadlocked.
A change of sleep will likely fix this, but there are other issues, so cleaning up the test a little.

Remove the probe for the ManagementFactory class, to check we are on jdk5 or later. 8-)

When sleeping, sleep 100, not 1ms, we don't need to spin fast and actually race with the other thread.

We have a 1000 iteration loop, but don't seem to use it. We only check once then either return (pass), fail, or break (which is also fail). Use the loop to check for the status change, which is likely what was intended.

Show the stackframes on all failures.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8188784: javax/management/notification/BroadcasterSupportDeadlockTest.java - TEST FAILED: deadlock (Bug - P4)

Reviewers

• Chris Plummer (@plummercj - Reviewer) ⚠️ Review applies to 5237f1d8
• Leonid Mesnik (@lmesnik - Reviewer) ⚠️ Review applies to 5237f1d8

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18687/head:pull/18687
$ git checkout pull/18687

Update a local copy of the PR:
$ git checkout pull/18687
$ git pull https://git.openjdk.org/jdk.git pull/18687/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18687

View PR using the GUI difftool:
$ git pr show -t 18687

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18687.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back kevinw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@kevinjwalls This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8188784: javax/management/notification/BroadcasterSupportDeadlockTest.java - TEST FAILED: deadlock

Reviewed-by: cjplummer, lmesnik

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@kevinjwalls The following labels will be automatically applied to this pull request:

• jmx
• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (a77b3c85)
• 00: Full (5237f1d8)

[plummercj]

Looks good.

[kevinjwalls]

Thanks for the reviews!

[kevinjwalls]

/integrate

[openjdk]

Going to push as commit 58911cc.

[openjdk]

@kevinjwalls Pushed as commit 58911cc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.