8329962: Remove CardTable::invalidate

[albertnetymk]

Simple converting redundant if-check to assert.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8329962: Remove CardTable::invalidate (Enhancement - P4)

Reviewers

• Thomas Schatzl (@tschatzl - Reviewer)
• Guoxiong Li (@lgxbslgx - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18696/head:pull/18696
$ git checkout pull/18696

Update a local copy of the PR:
$ git checkout pull/18696
$ git pull https://git.openjdk.org/jdk.git pull/18696/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18696

View PR using the GUI difftool:
$ git pr show -t 18696

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18696.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8329962: Remove CardTable::invalidate

Reviewed-by: tschatzl, gli

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 46 new commits pushed to the master branch:

• ece7d43: 8329416: Split relocation pointer map into read-write and read-only maps
• 0db4290: 8330049: Remove unused AbstractLinker::linkerByteOrder
• 5808f30: 8330026: Serial: Move some includes to vmStructs_serial.hpp
• 31ee510: 8241503: C2: Share MacroAssembler between mach nodes during code emission
• 0656f08: 8329469: Generational ZGC: Move the methods forwarding_[index|find|insert] from zRelocate.cpp to ZForwarding
• 1606187: 8326947: Minimize MakeBase.gmk
• 2e3682a: 8319678: Several tests from corelibs areas ignore VM flags
• 63684cd: 8327250: assert(!method->is_old()) failed: Should not be installing old methods
• ecc603c: 8201183: sjavac build failures: "Connection attempt failed: Connection refused"
• ff5c9a4: 8329528: G1 does not update TAMS correctly when dropping retained regions during Concurrent Start pause
• ... and 36 more: https://git.openjdk.org/jdk/compare/5fb5e6c8f04e325cbb782431d51251edde4c2618...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@albertnetymk The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (d8675100)

[albertnetymk]

/label add hotspot-gc

[openjdk]

@albertnetymk
The hotspot-gc label was successfully added.

[tschatzl]

lgtm.

[lgxbslgx]

Looks good.

[lgxbslgx]

The CardTable::invalidate can dirty a memory region cross generational boundary. But actually, we always only want to dirty the regions of one of the two generations instead of crossing them. So it is good to remove CardTable::invalidate.

Is my understanding above right?

[albertnetymk]

True; the passed-in mem-region corresponds to an obj, which should never cross the gen-boundary.

[albertnetymk]

Thanks for review.

/integrate

[openjdk]

Going to push as commit 006a516.
Since your change was applied there have been 51 commits pushed to the master branch:

• c7fcd62: 8330006: Serial: Extract out ContiguousSpace::block_start_const
• 2c8b432: 8330003: Serial: Move the logic of FastEvacuateFollowersClosure to SerialHeap
• 2c45eca: 8328879: G1: Some gtests modify global state crashing the JVM during GC after JDK-8289822
• bde3fc0: 8330106: C2: VectorInsertNode::make() shouldn't call ConINode::make() directly
• e45fea5: 8329757: Crash with fatal error: DEBUG MESSAGE: Fast Unlock lock on stack
• ece7d43: 8329416: Split relocation pointer map into read-write and read-only maps
• 0db4290: 8330049: Remove unused AbstractLinker::linkerByteOrder
• 5808f30: 8330026: Serial: Move some includes to vmStructs_serial.hpp
• 31ee510: 8241503: C2: Share MacroAssembler between mach nodes during code emission
• 0656f08: 8329469: Generational ZGC: Move the methods forwarding_[index|find|insert] from zRelocate.cpp to ZForwarding
• ... and 41 more: https://git.openjdk.org/jdk/compare/5fb5e6c8f04e325cbb782431d51251edde4c2618...master

Your commit was automatically rebased without conflicts.

[openjdk]

@albertnetymk Pushed as commit 006a516.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.