8253173: Print heap before and after GC lacks a newline

[stefank]

When GC logging was converted to Unified Logging a newline went missing.

-  st->print_cr("{Heap before GC invocations=%u (full %u):",
-               heap()->total_collections(),
-               heap()->total_full_collections());

vs

+  LogHandle(gc, heap) log;
+  if (log.is_trace()) {
+    log.trace("Heap before GC invocations=%u (full %u):", heap()->total_collections(), heap()->total_full_collections());

This gives lines like this:

GC(29) Heap after GC invocations=30 (full 30): ZHeap           used 20M, capacity 2014M, max capacity 30718M
GC(29)  Metaspace       used 6779K, capacity 6857K, committed 7040K, reserved 1056768K
GC(29)   class space    used 574K, capacity 620K, committed 640K, reserved 1048576K

Instead of:

GC(29) Heap after GC invocations=30 (full 30):
GC(29)  ZHeap           used 20M, capacity 2014M, max capacity 30718M
GC(29)  Metaspace       used 6779K, capacity 6857K, committed 7040K, reserved 1056768K
GC(29)   class space    used 574K, capacity 620K, committed 640K, reserved 1048576K

In our hs_err files we print this with a newline:

st.print_cr("{Heap %s GC invocations=%u (full %u):",
            before ? "before" : "after",
            heap->total_collections(),
            heap->total_full_collections());

I propse that we add this missing newline.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8253173: Print heap before and after GC lacks a newline

Reviewers

• Thomas Schatzl (@tschatzl - Reviewer)
• Per Lidén (@pliden - Reviewer)
• Roman Kennke (@rkennke - Reviewer)
• Stefan Johansson (@kstefanj - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/187/head:pull/187
$ git checkout pull/187

[bridgekeeper]

👋 Welcome back stefank! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@stefank The following label will be automatically applied to this pull request: hotspot.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

[stefank]

/label add hotspot-gc

[openjdk]

@stefank
The hotspot-gc label was successfully added.

[stefank]

/label remove hotspot

[openjdk]

@stefank
The hotspot label was successfully removed.

[mlbridge]

Webrevs

• 00: Full (20aab9d)

[openjdk]

@stefank This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8253173: Print heap before and after GC lacks a newline

Reviewed-by: tschatzl, pliden, rkennke, sjohanss

• If you would like to add a summary, use the /summary command.
• To credit additional contributors, use the /contributor command.
• To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 16 commits pushed to the master branch:

• f509eb0: 8253219: Epsilon: clean up unnecessary includes
• 7f9b5d9: 8253220: Epsilon: clean up unused code/declarations
• e0cf023: 8245309: Re-examine use of ThreadLocalCoders in sun.net.www.ParseUtil
• 60c4902: 8253016: Box.Filler components should be unfocusable by default
• dd43533: 8253222: Shenandoah: unused AlwaysTrueClosure after JDK-8246591
• efe3540: 8252966: CI: Remove KILL_COMPILE_ON_FATAL_ and KILL_COMPILE_ON_ANY macros
• fbf4699: 8253040: Remove unused Matcher::regnum_to_fpu_offset()
• 7c564e1: 8253146: C2: Purge unused MachCallNode::_arg_size field
• 2caa20a: 8250668: Clean up method_oop names in adlc
• 57f92d2: 8220483: Calendar.setTime(Date date) throws NPE with Date date = null
• ... and 6 more: https://git.openjdk.java.net/jdk/compare/74851c507bed9eb2e1e0b0eac3b53a74decb2588...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate f509eb069da3a482c1d4e58d959c79f8cb729fdd.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mlbridge]

Mailing list message from Thomas Schatzl on hotspot-gc-dev:

Hi,

On 15.09.20 17:17, Stefan Karlsson wrote:

When GC logging was converted to Unified Logging a newline went missing.

[...]

lgtm.

Thomas

[pliden]

Looks good!

[rkennke]

Looks good to me.

[stefank]

/integrate

[openjdk]

@stefank Since your change was applied there have been 16 commits pushed to the master branch:

• f509eb0: 8253219: Epsilon: clean up unnecessary includes
• 7f9b5d9: 8253220: Epsilon: clean up unused code/declarations
• e0cf023: 8245309: Re-examine use of ThreadLocalCoders in sun.net.www.ParseUtil
• 60c4902: 8253016: Box.Filler components should be unfocusable by default
• dd43533: 8253222: Shenandoah: unused AlwaysTrueClosure after JDK-8246591
• efe3540: 8252966: CI: Remove KILL_COMPILE_ON_FATAL_ and KILL_COMPILE_ON_ANY macros
• fbf4699: 8253040: Remove unused Matcher::regnum_to_fpu_offset()
• 7c564e1: 8253146: C2: Purge unused MachCallNode::_arg_size field
• 2caa20a: 8250668: Clean up method_oop names in adlc
• 57f92d2: 8220483: Calendar.setTime(Date date) throws NPE with Date date = null
• ... and 6 more: https://git.openjdk.java.net/jdk/compare/74851c507bed9eb2e1e0b0eac3b53a74decb2588...master

Your commit was automatically rebased without conflicts.

Pushed as commit 33f8e70.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.