8328822: C2: "negative trip count?" assert failure in profile predicate code

[rwestrel]

The assert failure is caused by:

ABS(min_jint) = min_jint

Given the ABS is part of a floating computation, the fix I propose
is to cast the value to float before the ABS.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8328822: C2: "negative trip count?" assert failure in profile predicate code (Bug - P3)

Reviewers

• Aleksey Shipilev (@shipilev - Reviewer)
• Christian Hagedorn (@chhagedorn - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18707/head:pull/18707
$ git checkout pull/18707

Update a local copy of the PR:
$ git checkout pull/18707
$ git pull https://git.openjdk.org/jdk.git pull/18707/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18707

View PR using the GUI difftool:
$ git pr show -t 18707

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18707.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back roland! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@rwestrel This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8328822: C2: "negative trip count?" assert failure in profile predicate code

Reviewed-by: shade, chagedorn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 71 new commits pushed to the master branch:

• 70944ca: 8330033: com/sun/net/httpserver/bugs/B6431193.java fails in AssertionError after JDK-8326568
• 279ed0d: 8329961: Buffer overflow in os::Linux::kernel_version
• 9731b1c: 8327137: Add test for ConcurrentModificationException in BasicDirectoryModel
• c5150c7: 8309751: Duplicate constant pool entries added during default method processing
• 86cb767: 8326568: jdk/test/com/sun/net/httpserver/bugs/B6431193.java should use try-with-resource and try-finally
• b49ba42: 8330002: Remove redundant public keyword in BarrierSet
• dd6e453: 8329767: G1: Move G1BlockOffsetTable::set_for_starts_humongous to HeapRegion
• e0fd6c4: 8329545: [s390x] Fix garbage value being passed in Argument Register
• 51ed69a: 8327621: Check return value of uname in os::get_host_name
• bea9acc: 8328482: Convert and Open source few manual applet test to main based
• ... and 61 more: https://git.openjdk.org/jdk/compare/18c925cd33d6f3b1d4365d582dddaa8426f41bea...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@rwestrel The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (13ef3844)

[shipilev]

Looks good and simple enough to me.

[chhagedorn]

Looks good to me, too.

[rwestrel]

@shipilev @chhagedorn thanks for the reviews

[rwestrel]

/integrate

[openjdk]

Going to push as commit 2ceeb6c.
Since your change was applied there have been 75 commits pushed to the master branch:

• b04b304: 8329254: optimize integral reverse operations on x86 GFNI target.
• d9c84e7: 8329656: assertion failed in MAP_ARCHIVE_MMAP_FAILURE path: Invalid immediate -5 0
• 5e544f1: 8329491: GetThreadListStackTraces function should use JvmtiHandshake
• 643dd48: 8329432: PopFrame and ForceEarlyReturn functions should use JvmtiHandshake
• 70944ca: 8330033: com/sun/net/httpserver/bugs/B6431193.java fails in AssertionError after JDK-8326568
• 279ed0d: 8329961: Buffer overflow in os::Linux::kernel_version
• 9731b1c: 8327137: Add test for ConcurrentModificationException in BasicDirectoryModel
• c5150c7: 8309751: Duplicate constant pool entries added during default method processing
• 86cb767: 8326568: jdk/test/com/sun/net/httpserver/bugs/B6431193.java should use try-with-resource and try-finally
• b49ba42: 8330002: Remove redundant public keyword in BarrierSet
• ... and 65 more: https://git.openjdk.org/jdk/compare/18c925cd33d6f3b1d4365d582dddaa8426f41bea...master

Your commit was automatically rebased without conflicts.

[openjdk]

@rwestrel Pushed as commit 2ceeb6c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.