8201183: sjavac build failures: "Connection attempt failed: Connection refused"

[djelinski]

The "Connection attempt failed: Connection refused" error may happen if the client tries to connect to a server that is no longer listening, which in turn may happen if the server shuts down without removing the port file. I added a check that the delete operation succeeded, and retry as necessary.

I removed the comment about asynchronous deletes on Windows. I don't think it's correct; it's more likely that the file existed because the delete operation failed.

I added a 1 second delay after deleting the port file; this delay is intended to allow any clients that managed to read the port file before it was deleted to finish connecting. It should also take care of the "IOException caught during compilation: Connection reset" issue.

And finally, the portfile is now closed when not in use. This was necessary to fix the failures on Windows, where the file cannot be deleted as long as it is open in any process.

In order to verify the fix, I modified IdleMonitor.KEEPALIVE to 1 second. Without the changes from this PR this resulted in at least a few failures in every mach5 run. With this PR I was able to build tier1-5 with no failures.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8201183: sjavac build failures: "Connection attempt failed: Connection refused" (Bug - P4)

Reviewers

• Erik Joelsson (@erikj79 - Reviewer)
• Magnus Ihse Bursie (@magicus - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18712/head:pull/18712
$ git checkout pull/18712

Update a local copy of the PR:
$ git checkout pull/18712
$ git pull https://git.openjdk.org/jdk.git pull/18712/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18712

View PR using the GUI difftool:
$ git pr show -t 18712

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18712.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back djelinski! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@djelinski This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8201183: sjavac build failures: "Connection attempt failed: Connection refused"

Reviewed-by: erikj, ihse

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 34 new commits pushed to the master branch:

• f0cd866: 8329704: Implement framework for proper handling of JDK_LIBS
• 8817ba4: 8330000: ZGC: ZObjArrayAllocator may unnecessarily clear TypeArrays twice
• f778642: 8330024: [AIX] replace my_disclaim64 helper by direct call to disclaim64
• 7df4926: 8327741: JVM crash in hotspot/share/opto/compile.cpp - failed: missing inlining msg
• 2ceeb6c: 8328822: C2: "negative trip count?" assert failure in profile predicate code
• b04b304: 8329254: optimize integral reverse operations on x86 GFNI target.
• d9c84e7: 8329656: assertion failed in MAP_ARCHIVE_MMAP_FAILURE path: Invalid immediate -5 0
• 5e544f1: 8329491: GetThreadListStackTraces function should use JvmtiHandshake
• 643dd48: 8329432: PopFrame and ForceEarlyReturn functions should use JvmtiHandshake
• 70944ca: 8330033: com/sun/net/httpserver/bugs/B6431193.java fails in AssertionError after JDK-8326568
• ... and 24 more: https://git.openjdk.org/jdk/compare/3b6629cec7a2ecec8dcb5b94d8ed3e169483aa97...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@djelinski The following labels will be automatically applied to this pull request:

• build
• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (d9341cf7)

[magicus]

Thank you very much for spending the time and effort of fixing these intermittent javac server issues!

[djelinski]

Thanks for the reviews!

/integrate

[openjdk]

Going to push as commit ecc603c.
Since your change was applied there have been 36 commits pushed to the master branch:

• ff5c9a4: 8329528: G1 does not update TAMS correctly when dropping retained regions during Concurrent Start pause
• 9acce7a: 8329774: Break long lines in jdk/src/jdk.hotspot.agent/doc /transported_core.html
• f0cd866: 8329704: Implement framework for proper handling of JDK_LIBS
• 8817ba4: 8330000: ZGC: ZObjArrayAllocator may unnecessarily clear TypeArrays twice
• f778642: 8330024: [AIX] replace my_disclaim64 helper by direct call to disclaim64
• 7df4926: 8327741: JVM crash in hotspot/share/opto/compile.cpp - failed: missing inlining msg
• 2ceeb6c: 8328822: C2: "negative trip count?" assert failure in profile predicate code
• b04b304: 8329254: optimize integral reverse operations on x86 GFNI target.
• d9c84e7: 8329656: assertion failed in MAP_ARCHIVE_MMAP_FAILURE path: Invalid immediate -5 0
• 5e544f1: 8329491: GetThreadListStackTraces function should use JvmtiHandshake
• ... and 26 more: https://git.openjdk.org/jdk/compare/3b6629cec7a2ecec8dcb5b94d8ed3e169483aa97...master

Your commit was automatically rebased without conflicts.

[openjdk]

@djelinski Pushed as commit ecc603c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.