Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8258186: Replace use of JNI_COMMIT mode with mode 0 #1875

Closed
wants to merge 1 commit into from

Conversation

valeriepeng
Copy link
Contributor

@valeriepeng valeriepeng commented Dec 23, 2020

Could someone please help review this trivial change - just replace JNI_COMMIT with 0 for all ReleasePrimitiveArrayCritical calls.

Thanks,
Valerie


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8258186: Replace use of JNI_COMMIT mode with mode 0

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1875/head:pull/1875
$ git checkout pull/1875

Replaced JNI_COMMIT with 0 for all ReleasePrimitiveArrayCritical calls
@bridgekeeper
Copy link

bridgekeeper bot commented Dec 23, 2020

👋 Welcome back valeriep! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 23, 2020
@openjdk
Copy link

openjdk bot commented Dec 23, 2020

@valeriepeng The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label Dec 23, 2020
@mlbridge
Copy link

mlbridge bot commented Dec 23, 2020

Webrevs

Copy link
Member

@XueleiFan XueleiFan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks a safe update to me.

@openjdk
Copy link

openjdk bot commented Dec 23, 2020

@valeriepeng This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8258186: Replace use of JNI_COMMIT mode with mode 0

Reviewed-by: xuelei, alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 4ea8851: 8257928: Test image build failure with clang-10 due to -Wmisleading-indentation

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 23, 2020
@valeriepeng
Copy link
Contributor Author

Thanks for the review.

@valeriepeng
Copy link
Contributor Author

/integrate

@openjdk openjdk bot closed this Dec 23, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 23, 2020
@openjdk
Copy link

openjdk bot commented Dec 23, 2020

@valeriepeng Since your change was applied there have been 5 commits pushed to the master branch:

  • e46edb5: 8258911: ProblemList serviceability/attach/RemovingUnixDomainSocketTest.java on Linux-X64
  • 91244cc: 8258557: Deproblemlist fixed problemlisted test
  • 2445735: 8258837: Remove JVM option DisableStartThread
  • a4e082e: 8253368: TLS connection always receives close_notify exception
  • 4ea8851: 8257928: Test image build failure with clang-10 due to -Wmisleading-indentation

Your commit was automatically rebased without conflicts.

Pushed as commit cd94606.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated security security-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

3 participants