8326116: JFR: Add help option to -XX:StartFlightRecording

[egahlin]

Could I have review of an enhancement that adds a help option to -XX:StartFlightRecording similar to -Xlog:help.

Testing: jdk/jdk/jfr + tier1 + tier2

Thanks
Erik

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change requires CSR request JDK-8326338 to be approved

Issues

• JDK-8326116: JFR: Add help option to -XX:StartFlightRecording (Bug - P4)
• JDK-8326338: JFR: Add help option to -XX:StartFlightRecording (CSR)

Reviewers

• Markus Grönlund (@mgronlun - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18765/head:pull/18765
$ git checkout pull/18765

Update a local copy of the PR:
$ git checkout pull/18765
$ git pull https://git.openjdk.org/jdk.git pull/18765/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18765

View PR using the GUI difftool:
$ git pr show -t 18765

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18765.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8326116: JFR: Add help option to -XX:StartFlightRecording

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 43 new commits pushed to the master branch:

• 8a5b86c: 8196106: Support nested infinite or recursive flat mapped streams
• 58911cc: 8188784: javax/management/notification/BroadcasterSupportDeadlockTest.java - TEST FAILED: deadlock
• 97c1808: 8329099: Undocumented exception thrown by Instruction factory methods accepting Opcode
• def2577: 8330215: Trim working set for OldObjectSamples
• 2f11afd: 8330172: G1: Consolidate update_bot_for_block and update_bot_for_obj in HeapRegion
• 31a1f9c: 8307143: CredentialsCache.cacheName should not be static
• 274c805: 8327743: JVM crash in hotspot/share/runtime/javaThread.cpp - failed: held monitor count should be equal to jni: 0 != 1
• 140f567: 8323220: Reassociate loop invariants involved in Cmps and Add/Subs
• a293bdf: 8330197: Make javac/diags/example release agnostic
• da75e01: 8330196: Make java/lang/invoke/defineHiddenClass/BasicTest release agnostic
• ... and 33 more: https://git.openjdk.org/jdk/compare/16061874ffdd1b018fe1cad7e6d8ba8bdbdbbee1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@egahlin The following label will be automatically applied to this pull request:

• hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (07386d16)

[egahlin]

/integrate

[openjdk]

Going to push as commit f7c8413.
Since your change was applied there have been 52 commits pushed to the master branch:

• 941bee1: 8327640: Allow NumberFormat strict parsing
• 2ede143: 8330279: Typo in java.text.Bidi class description
• 90df3b7: 8329190: (ch) DatagramChannel.receive should throw ClosedChannelException when called on closed channel
• f11a496: 8180450: secondary_super_cache does not scale well
• bfff02e: 8330165: C2: make superword consistently use PhaseIdealLoop::register_new_node()
• e073d5b: 8329665: fatal error: memory leak: allocating without ResourceMark
• 6e77d91: 8330261: Clean up linking steps
• 61fa4d4: 8330351: Remove the SHARED_LIBRARY and STATIC_LIBRARY macros
• 56ff87a: 8330359: G1: Remove unused forward declaration in g1BlockOffsetTable.hpp
• 8a5b86c: 8196106: Support nested infinite or recursive flat mapped streams
• ... and 42 more: https://git.openjdk.org/jdk/compare/16061874ffdd1b018fe1cad7e6d8ba8bdbdbbee1...master

Your commit was automatically rebased without conflicts.

[openjdk]

@egahlin Pushed as commit f7c8413.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.