8330262: C2: simplify transfer of GC barrier data from Ideal to Mach nodes

[robcasloz]

This (trivial?) cleanup reuses MemNode::barrier_data() (added recently by JDK-8322692) to compute the GC barrier data to be transferred from Ideal nodes to their corresponding Mach nodes in Matcher::ReduceInst().

Testing: tier1-3 (windows-x64, linux-x64, linux-aarch64, and macosx-x64; release and debug mode).

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8330262: C2: simplify transfer of GC barrier data from Ideal to Mach nodes (Enhancement - P4)

Reviewers

• Erik Österlund (@fisk - Reviewer)
• Vladimir Kozlov (@vnkozlov - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18784/head:pull/18784
$ git checkout pull/18784

Update a local copy of the PR:
$ git checkout pull/18784
$ git pull https://git.openjdk.org/jdk.git pull/18784/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18784

View PR using the GUI difftool:
$ git pr show -t 18784

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18784.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back rcastanedalo! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@robcasloz This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8330262: C2: simplify transfer of GC barrier data from Ideal to Mach nodes

Reviewed-by: eosterlund, kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 49 new commits pushed to the master branch:

• 31a1f9c: 8307143: CredentialsCache.cacheName should not be static
• 274c805: 8327743: JVM crash in hotspot/share/runtime/javaThread.cpp - failed: held monitor count should be equal to jni: 0 != 1
• 140f567: 8323220: Reassociate loop invariants involved in Cmps and Add/Subs
• a293bdf: 8330197: Make javac/diags/example release agnostic
• da75e01: 8330196: Make java/lang/invoke/defineHiddenClass/BasicTest release agnostic
• ddc3921: 8330103: Compiler memory statistics should keep separate records for C1 and C2
• 273df62: 8328792: Parallel: Refactor PSParallelCompact::summary_phase
• a3fecdb: 8329764: G1: Handle null references during verification first
• 60d88b7: 8330176: Typo in Linker javadoc
• 3f1d9c4: 8329257: AIX: Switch HOTSPOT_TOOLCHAIN_TYPE from xlc to gcc
• ... and 39 more: https://git.openjdk.org/jdk/compare/b04b3047ff5c5526bdf47925210e2a35ca191e6e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@robcasloz The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (1030f0ad)

[fisk]

Looks good.

[robcasloz]

Looks good.

Thanks for reviewing, Erik!

[vnkozlov]

Good.

[robcasloz]

Good.

Thanks, Vladimir!

[robcasloz]

/integrate

[openjdk]

Going to push as commit 9d63fee.
Since your change was applied there have been 73 commits pushed to the master branch:

• 01bda27: 8330011: [s390x] update block-comments to make code consistent
• 2fe2f3a: 8323900: Avoid calling os::init_random() in CDS static dump
• cd4c3aa: 8330242: RISC-V: Simplify and remove CORRECT_COMPILER_ATOMIC_SUPPORT in atomic_linux_riscv.hpp
• e57a322: 8329970: Update autoconf build-aux files with latest from 2024-01-01
• c8702ed: 8330213: RISC-V: C2: assert(false) failed: bad AD file after JDK-8316991
• f6f038a: 8317368: [JVMCI] SIGSEGV in JVMCIEnv::initialize_installed_code on libgraal
• fb4cf1c: 8329636: Deprecate -XX:+PreserveAllAnnotations
• d1c6cd1: 8330133: libj2pkcs11.so crashes on some pkcs#11 v3.0 libraries
• 76cbe48: 8329430: MetaspaceShared::preload_and_dump should clear pending exception
• f7c8413: 8326116: JFR: Add help option to -XX:StartFlightRecording
• ... and 63 more: https://git.openjdk.org/jdk/compare/b04b3047ff5c5526bdf47925210e2a35ca191e6e...master

Your commit was automatically rebased without conflicts.

[openjdk]

@robcasloz Pushed as commit 9d63fee.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.