8330351: Remove the SHARED_LIBRARY and STATIC_LIBRARY macros

[magicus]

The macros SHARED_LIBRARY and STATIC_LIBRARY are weird (they do not fit in with naming and placement of other macros), and almost never used. We should just get rid of them.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8330351: Remove the SHARED_LIBRARY and STATIC_LIBRARY macros (Bug - P3)

Reviewers

• Erik Joelsson (@erikj79 - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18793/head:pull/18793
$ git checkout pull/18793

Update a local copy of the PR:
$ git checkout pull/18793
$ git pull https://git.openjdk.org/jdk.git pull/18793/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18793

View PR using the GUI difftool:
$ git pr show -t 18793

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18793.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ihse! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@magicus This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8330351: Remove the SHARED_LIBRARY and STATIC_LIBRARY macros

Reviewed-by: erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• 8a5b86c: 8196106: Support nested infinite or recursive flat mapped streams
• 58911cc: 8188784: javax/management/notification/BroadcasterSupportDeadlockTest.java - TEST FAILED: deadlock

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@magicus The following labels will be automatically applied to this pull request:

• build
• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[magicus]

/label -core-libs

[openjdk]

@magicus
The core-libs label was successfully removed.

[mlbridge]

Webrevs

• 00: Full (26eff74d)

[magicus]

/integrate

[openjdk]

Going to push as commit 61fa4d4.
Since your change was applied there have been 3 commits pushed to the master branch:

• 56ff87a: 8330359: G1: Remove unused forward declaration in g1BlockOffsetTable.hpp
• 8a5b86c: 8196106: Support nested infinite or recursive flat mapped streams
• 58911cc: 8188784: javax/management/notification/BroadcasterSupportDeadlockTest.java - TEST FAILED: deadlock

Your commit was automatically rebased without conflicts.

[openjdk]

@magicus Pushed as commit 61fa4d4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.