8330280: SharedRuntime::get_resolved_entry should not return c2i entry if the callee is special native intrinsic

[mur47x111]

In #18741 we return c2i entry for threads with interp_only_mode. This can be problematic for method handle intrinsics and continuation intrinsics, which cannot be interpreted. Consequently, we will cascade the c2i entry with an i2c entry and fail the runtime. The solution is to not return c2i entry under such circumstance.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8330280: SharedRuntime::get_resolved_entry should not return c2i entry if the callee is special native intrinsic (Bug - P3)

Reviewers

• Patricio Chilano Mateo (@pchilano - Reviewer)
• Dean Long (@dean-long - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18799/head:pull/18799
$ git checkout pull/18799

Update a local copy of the PR:
$ git checkout pull/18799
$ git pull https://git.openjdk.org/jdk.git pull/18799/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18799

View PR using the GUI difftool:
$ git pr show -t 18799

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18799.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back yzheng! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mur47x111 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8330280: SharedRuntime::get_resolved_entry should not return c2i entry if the callee is special native intrinsic

Reviewed-by: pchilanomate, dlong

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 28 new commits pushed to the master branch:

• 7744b00: 8327946: containers/docker/TestJFREvents.java fails when host kernel config vm.swappiness=0 after JDK-8325139
• 9d63fee: 8330262: C2: simplify transfer of GC barrier data from Ideal to Mach nodes
• 01bda27: 8330011: [s390x] update block-comments to make code consistent
• 2fe2f3a: 8323900: Avoid calling os::init_random() in CDS static dump
• cd4c3aa: 8330242: RISC-V: Simplify and remove CORRECT_COMPILER_ATOMIC_SUPPORT in atomic_linux_riscv.hpp
• e57a322: 8329970: Update autoconf build-aux files with latest from 2024-01-01
• c8702ed: 8330213: RISC-V: C2: assert(false) failed: bad AD file after JDK-8316991
• f6f038a: 8317368: [JVMCI] SIGSEGV in JVMCIEnv::initialize_installed_code on libgraal
• fb4cf1c: 8329636: Deprecate -XX:+PreserveAllAnnotations
• d1c6cd1: 8330133: libj2pkcs11.so crashes on some pkcs#11 v3.0 libraries
• ... and 18 more: https://git.openjdk.org/jdk/compare/140f56718bbbfc31bb0c39255c68568fad285a1f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@pchilano, @dean-long) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@mur47x111 The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (585439de)

[pchilano]

Looks good to me, thanks Yudi.

[mur47x111]

/integrate

[openjdk]

@mur47x111
Your change (at version 585439d) is now ready to be sponsored by a Committer.

[dougxc]

/sponsor

[openjdk]

Going to push as commit 3ccbc6d.
Since your change was applied there have been 28 commits pushed to the master branch:

• 7744b00: 8327946: containers/docker/TestJFREvents.java fails when host kernel config vm.swappiness=0 after JDK-8325139
• 9d63fee: 8330262: C2: simplify transfer of GC barrier data from Ideal to Mach nodes
• 01bda27: 8330011: [s390x] update block-comments to make code consistent
• 2fe2f3a: 8323900: Avoid calling os::init_random() in CDS static dump
• cd4c3aa: 8330242: RISC-V: Simplify and remove CORRECT_COMPILER_ATOMIC_SUPPORT in atomic_linux_riscv.hpp
• e57a322: 8329970: Update autoconf build-aux files with latest from 2024-01-01
• c8702ed: 8330213: RISC-V: C2: assert(false) failed: bad AD file after JDK-8316991
• f6f038a: 8317368: [JVMCI] SIGSEGV in JVMCIEnv::initialize_installed_code on libgraal
• fb4cf1c: 8329636: Deprecate -XX:+PreserveAllAnnotations
• d1c6cd1: 8330133: libj2pkcs11.so crashes on some pkcs#11 v3.0 libraries
• ... and 18 more: https://git.openjdk.org/jdk/compare/140f56718bbbfc31bb0c39255c68568fad285a1f...master

Your commit was automatically rebased without conflicts.

[openjdk]

@dougxc @mur47x111 Pushed as commit 3ccbc6d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.