8265474: Dubious 'null' assignment in CompactByteArray.expand #1880

turbanoff · 2020-12-23T16:06:30Z

I propose to remove 'null' assignment of field CompactByteArray.values in expand method. In the next statement this field is overridden with another value - tempArray.
This code was there from initial load of OpenJDK sources. I believe it was just leftovers from development phase of this class. There is no practical reason to assign null to non-volatile field and then overwrite it with another value.
Also I've removed unused method getArray. I hope it's ok to cleanup such unused stuff in the same PR.

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Issue

JDK-8265474: Dubious 'null' assignment in CompactByteArray.expand

Reviewers

Alan Bateman (@AlanBateman - Reviewer)
Naoto Sato (@naotoj - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/1880/head:pull/1880
$ git checkout pull/1880

Update a local copy of the PR:
$ git checkout pull/1880
$ git pull https://git.openjdk.java.net/jdk pull/1880/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1880

View PR using the GUI difftool:
$ git pr show -t 1880

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/1880.diff

bridgekeeper · 2020-12-23T16:07:30Z

👋 Welcome back turbanoff! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2020-12-23T16:08:28Z

@turbanoff The following label will be automatically applied to this pull request:

core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

bridgekeeper · 2021-01-20T17:46:38Z

@turbanoff This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper · 2021-02-17T18:57:33Z

@turbanoff This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it!

turbanoff · 2021-04-25T14:21:29Z

/open

openjdk · 2021-04-25T14:22:23Z

@turbanoff @HostUserDetails{id=741251, username='turbanoff', fullName='null'} this pull request is now open

update copyright year

mlbridge · 2021-04-25T14:28:41Z

Webrevs

00: Full (cf182476)

bridgekeeper · 2021-05-23T17:08:45Z

@turbanoff This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

turbanoff · 2021-06-14T14:34:33Z

Let's keep open this PR with cleanup.

bridgekeeper · 2021-07-12T14:48:16Z

@turbanoff This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

AlanBateman

This cleanup looks okay, @naotoj?

openjdk · 2021-07-23T15:19:28Z

@turbanoff This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8265474: Dubious 'null' assignment in CompactByteArray.expand

Reviewed-by: alanb, naoto

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3015 new commits pushed to the master branch:

e627cae: 8270317: Large Allocation in CipherSuite
0dcfc42: Merge
8adf008: 8269984: [macos] JTabbedPane title looks like disabled
e90ed6c: 8271173: serviceability/jvmti/GetObjectSizeClass.java doesn't check exit code
b4c6229: 8271189: runtime/handshake/HandshakeTimeoutTest.java can be run in driver mode
7468bbc: 8266988: compiler/jvmci/compilerToVM/IsMatureTest.java fails with Unexpected isMature state for multiple times invoked method: expected false to equal true
286106d: 8271219: [REDO] JDK-8271063 Print injected fields for InstanceKlass
a1c0a6a: 8199594: Add doc describing how (?x) ignores spaces in character classes
4ed548b: 8268261: C2: assert(n != __null) failed: Bad immediate dominator info.
ec71e2d: 8271221: [BACKOUT] JDK-8271063 Print injected fields for InstanceKlass
... and 3005 more: https://git.openjdk.java.net/jdk/compare/4ea88512ddb89470ff5a043bc1865b9e4af661d6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@AlanBateman, @naotoj) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

naotoj

Yes, it does.

turbanoff · 2021-07-24T12:40:30Z

/integrate

openjdk · 2021-07-24T12:41:43Z

@turbanoff
Your change (at version cf18247) is now ready to be sponsored by a Committer.

naotoj · 2021-07-26T16:17:14Z

/sponsor

openjdk · 2021-07-26T16:31:55Z

Going to push as commit ee55361.
Since your change was applied there have been 3019 commits pushed to the master branch:

515113d: 8269924: Shenandoah: Introduce weak/strong marking asserts
f2c359a: 8271215: Fix data races in G1PeriodicGCTask
36aefa3: 8270447: [IR Framework] Add missing compilation level restriction when using FlipC1C2 stress option
e4295cc: 8270519: Move several vector helper methods to shared header file
e627cae: 8270317: Large Allocation in CipherSuite
0dcfc42: Merge
8adf008: 8269984: [macos] JTabbedPane title looks like disabled
e90ed6c: 8271173: serviceability/jvmti/GetObjectSizeClass.java doesn't check exit code
b4c6229: 8271189: runtime/handshake/HandshakeTimeoutTest.java can be run in driver mode
7468bbc: 8266988: compiler/jvmci/compilerToVM/IsMatureTest.java fails with Unexpected isMature state for multiple times invoked method: expected false to equal true
... and 3009 more: https://git.openjdk.java.net/jdk/compare/4ea88512ddb89470ff5a043bc1865b9e4af661d6...master

Your commit was automatically rebased without conflicts.

openjdk · 2021-07-26T16:32:40Z

@naotoj @turbanoff Pushed as commit ee55361.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[PATCH] Remove dubious 'null' assignment to CompactByteArray.values

12f60af

openjdk bot added the core-libs label Dec 23, 2020

bridgekeeper bot closed this Feb 17, 2021

turbanoff changed the title ~~[PATCH] Remove dubious 'null' assignment to CompactByteArray.values~~ 8265474: Dubious 'null' assignment in CompactByteArray.expand Apr 25, 2021

openjdk bot reopened this Apr 25, 2021

openjdk bot added the rfr label Apr 25, 2021

8265474: Dubious 'null' assignment in CompactByteArray.expand

cf18247

update copyright year

AlanBateman approved these changes Jul 23, 2021

View changes

openjdk bot added the ready label Jul 23, 2021

naotoj approved these changes Jul 23, 2021

View changes

openjdk bot added the sponsor label Jul 24, 2021

openjdk bot closed this Jul 26, 2021

openjdk bot added integrated and removed ready rfr labels Jul 26, 2021

openjdk bot removed the sponsor label Jul 26, 2021

turbanoff deleted the field_CompactByteArray.values_is_assigned_twice branch Sep 15, 2021

8265474: Dubious 'null' assignment in CompactByteArray.expand #1880

8265474: Dubious 'null' assignment in CompactByteArray.expand #1880

turbanoff commented Dec 23, 2020 •

edited by openjdk[bot] bot

bridgekeeper bot commented Dec 23, 2020

openjdk bot commented Dec 23, 2020

bridgekeeper bot commented Jan 20, 2021

bridgekeeper bot commented Feb 17, 2021

turbanoff commented Apr 25, 2021

openjdk bot commented Apr 25, 2021

mlbridge bot commented Apr 25, 2021

bridgekeeper bot commented May 23, 2021

turbanoff commented Jun 14, 2021

bridgekeeper bot commented Jul 12, 2021

AlanBateman left a comment

openjdk bot commented Jul 23, 2021 •

edited

naotoj left a comment

turbanoff commented Jul 24, 2021

openjdk bot commented Jul 24, 2021

naotoj commented Jul 26, 2021

openjdk bot commented Jul 26, 2021

openjdk bot commented Jul 26, 2021

8265474: Dubious 'null' assignment in CompactByteArray.expand #1880

8265474: Dubious 'null' assignment in CompactByteArray.expand #1880

Conversation

turbanoff commented Dec 23, 2020 • edited by openjdk[bot] bot

Progress

Issue

Reviewers

Reviewing

bridgekeeper bot commented Dec 23, 2020

openjdk bot commented Dec 23, 2020

bridgekeeper bot commented Jan 20, 2021

bridgekeeper bot commented Feb 17, 2021

turbanoff commented Apr 25, 2021

openjdk bot commented Apr 25, 2021

mlbridge bot commented Apr 25, 2021

Webrevs

bridgekeeper bot commented May 23, 2021

turbanoff commented Jun 14, 2021

bridgekeeper bot commented Jul 12, 2021

AlanBateman left a comment

openjdk bot commented Jul 23, 2021 • edited

naotoj left a comment

turbanoff commented Jul 24, 2021

openjdk bot commented Jul 24, 2021

naotoj commented Jul 26, 2021

openjdk bot commented Jul 26, 2021

openjdk bot commented Jul 26, 2021

turbanoff commented Dec 23, 2020 •

edited by openjdk[bot] bot

openjdk bot commented Jul 23, 2021 •

edited