Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8329805: Deprecate for removal ObjectOutputStream.PutField.write #18802

Conversation

RogerRiggs
Copy link
Contributor

@RogerRiggs RogerRiggs commented Apr 16, 2024

The method java.io.ObjectOutputStream.PutField.write has been deprecated since 1.4 and should be deprecated for removal. The Deprecation annotation is updated to indicate the intention to remov the method.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8330413 to be approved

Issues

  • JDK-8329805: Deprecate for removal ObjectOutputStream.PutField.write (Bug - P4)
  • JDK-8330413: Deprecate for removal java.io.ObjectOutputStream.PutField.write (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18802/head:pull/18802
$ git checkout pull/18802

Update a local copy of the PR:
$ git checkout pull/18802
$ git pull https://git.openjdk.org/jdk.git pull/18802/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18802

View PR using the GUI difftool:
$ git pr show -t 18802

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18802.diff

Webrev

Link to Webrev Comment

@RogerRiggs
Copy link
Contributor Author

/csr

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 16, 2024

👋 Welcome back rriggs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 16, 2024

@RogerRiggs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8329805: Deprecate for removal ObjectOutputStream.PutField.write

Reviewed-by: naoto, iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 177 new commits pushed to the master branch:

  • df04358: 8330179: Clean up non-standard use of /** comments in jdk.compiler
  • c1dd82b: 8329644: Discuss expected visitor evolution patterns in javax.lang.model.util
  • b704e91: 8329433: Reduce nmethod header size
  • 8da175d: 8330008: [s390x] Test bit "in-memory" in case of DiagnoseSyncOnValueBasedClasses
  • 3c1d1d9: 8320522: Remove code related to RegisterFinalizersAtInit
  • 650ca65: 8329330: NoClassDefFoundError: Could not initialize class jdk.jfr.internal.MirrorEvents
  • 177092b: 8330569: Rename Nix to Posix in platform-dependent attachListener code
  • eb60822: 8310072: JComboBox/DisabledComboBoxFontTestAuto: Enabled and disabled ComboBox does not match in these LAFs: GTK+
  • 85261bc: 8330266: RISC-V: Restore frm to RoundingMode::rne after JNI
  • 9f2a4fa: 8330572: jdk.internal.net.http.HttpConnection calls an expensive checkOpen() when returning a HTTP/1.1 connection to the pool
  • ... and 167 more: https://git.openjdk.org/jdk/compare/6439375bb96346f4b34ba57e8e61ffe1905563f1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added csr Pull request needs approved CSR before integration rfr Pull request is ready for review labels Apr 16, 2024
@openjdk
Copy link

openjdk bot commented Apr 16, 2024

@RogerRiggs an approved CSR request is already required for this pull request.

@openjdk
Copy link

openjdk bot commented Apr 16, 2024

@RogerRiggs The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Apr 16, 2024
@mlbridge
Copy link

mlbridge bot commented Apr 16, 2024

Webrevs

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed csr Pull request needs approved CSR before integration labels Apr 19, 2024
@RogerRiggs
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 25, 2024

Going to push as commit 4dfaa9b.
Since your change was applied there have been 261 commits pushed to the master branch:

  • b9927aa: 8329194: Cleanup Type::cmp definition and usage
  • c944201: 8331031: unify os::dont_yield and os::naked_yield across Posix platforms
  • 8031dab: 8331094: ZGC: GTest fails due to incompatible Windows version
  • c9f8d0e: 8331050: Serial: Remove unused _saved_mark_word in DefNewGeneration and TenuredGeneration
  • b1b953c: 8330972: Serial: Inline Generation::max_contiguous_available
  • 87e864b: 8328703: Illegal accesses in Java_jdk_internal_org_jline_terminal_impl_jna_linux_CLibraryImpl_ioctl0
  • ef745a6: 8331097: Tests build is broken after pr/18914
  • d32f109: 8329797: Shenandoah: Default case invoked for: "MaxL" (bad AD file)
  • ccc0d0f: 8325373: Improve StackCounter error reporting for bad switch cases
  • e818ab6: 8330815: Use pattern matching for instanceof in KeepAliveCache
  • ... and 251 more: https://git.openjdk.org/jdk/compare/6439375bb96346f4b34ba57e8e61ffe1905563f1...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 25, 2024
@openjdk openjdk bot closed this Apr 25, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 25, 2024
@openjdk
Copy link

openjdk bot commented Apr 25, 2024

@RogerRiggs Pushed as commit 4dfaa9b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RogerRiggs RogerRiggs deleted the 8329805-oos-putfield-write-deprecate-removal branch June 24, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants