Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8239596: PARAMETER annotation on receiver type does not cause error #1881

Closed
wants to merge 3 commits into from

Conversation

lgxbslgx
Copy link
Member

@lgxbslgx lgxbslgx commented Dec 23, 2020

Hi all,

TypeAnnotationsValidator::visitMethodDef uses checkForDeclarationAnnotations incorrectly so that the check could not work as expected and some related errors are not reported. This patch fixes it and adds a corresponding test case.

Thank you for taking the time to review.

Best Regards.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8239596: PARAMETER annotation on receiver type does not cause error

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/1881/head:pull/1881
$ git checkout pull/1881

Update a local copy of the PR:
$ git checkout pull/1881
$ git pull https://git.openjdk.java.net/jdk pull/1881/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1881

View PR using the GUI difftool:
$ git pr show -t 1881

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/1881.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 23, 2020

👋 Welcome back lgxbslgx! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 23, 2020
@openjdk
Copy link

openjdk bot commented Dec 23, 2020

@lgxbslgx The following label will be automatically applied to this pull request:

  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the compiler compiler-dev@openjdk.org label Dec 23, 2020
@mlbridge
Copy link

mlbridge bot commented Dec 23, 2020

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 20, 2021

@lgxbslgx This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 17, 2021

@lgxbslgx This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it!

@bridgekeeper bridgekeeper bot closed this Feb 17, 2021
@lgxbslgx
Copy link
Member Author

/open

@openjdk openjdk bot reopened this Apr 22, 2021
@openjdk
Copy link

openjdk bot commented Apr 22, 2021

@lgxbslgx @HostUserDetails{id=13688759, username='lgxbslgx', fullName='null'} this pull request is now open

Copy link
Contributor

@vicente-romero-oracle vicente-romero-oracle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks sensible

@openjdk
Copy link

openjdk bot commented Apr 23, 2021

@lgxbslgx This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8239596: PARAMETER annotation on receiver type does not cause error

Reviewed-by: vromero

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • e08f506: 8265816: Handle new VectorMaskCast node for x86
  • bebfae4: 8264208: Console charset API
  • 5aab160: 8265531: doc/building.md should mention homebrew install freetype
  • d8e638f: 8265794: Remove ProblemList-non-cds-mode
  • ac23870: 8265831: 8257831 broke Windows x86 build
  • 8e31229: 8265327: Remove check_safepoint_and_suspend_for_native_trans()
  • c9b70c8: 8265240: runtime/Thread/SuspendAtExit.java needs updating
  • 891f72f: 8265606: Reduce allocations in AdapterHandlerLibrary::get_adapter
  • bfc1cd8: 8264320: ShouldNotReachHere in Compile::print_inlining_move_to()
  • 5db64c3: 8265268: Unify ReservedSpace reservation code in initialize and try_reserve_heap

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@vicente-romero-oracle) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 23, 2021
@lgxbslgx
Copy link
Member Author

@vicente-romero-oracle Thank you for your review. Could I get your help to sponsor this patch?

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Apr 23, 2021
@openjdk
Copy link

openjdk bot commented Apr 23, 2021

@lgxbslgx
Your change (at version 760685a) is now ready to be sponsored by a Committer.

@vicente-romero-oracle
Copy link
Contributor

/sponsor

@openjdk openjdk bot closed this Apr 24, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 24, 2021
@openjdk
Copy link

openjdk bot commented Apr 24, 2021

@vicente-romero-oracle @lgxbslgx Since your change was applied there have been 14 commits pushed to the master branch:

  • 52f9d22: 8265884: ProblemList compiler/codecache/jmx/PoolsIndependenceTest.java on macOS-X64
  • 5aed446: 8265403: consolidate definition of CPU features
  • 20a373a: 8265393: VM crashes if both -XX:+RecordDynamicDumpInfo and -XX:SharedArchiveFile options are specified
  • 6803ab2: 8265880: ProblemList serviceability/dcmd/gc/RunFinalizationTest.java on Linux-X64
  • e08f506: 8265816: Handle new VectorMaskCast node for x86
  • bebfae4: 8264208: Console charset API
  • 5aab160: 8265531: doc/building.md should mention homebrew install freetype
  • d8e638f: 8265794: Remove ProblemList-non-cds-mode
  • ac23870: 8265831: 8257831 broke Windows x86 build
  • 8e31229: 8265327: Remove check_safepoint_and_suspend_for_native_trans()
  • ... and 4 more: https://git.openjdk.java.net/jdk/compare/191f1fc46c30f7e92ba09d04bc000256442e64ed...master

Your commit was automatically rebased without conflicts.

Pushed as commit d87a4c3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@lgxbslgx lgxbslgx deleted the JDK-8239596 branch April 24, 2021 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler compiler-dev@openjdk.org integrated Pull request has been integrated
2 participants